[llvm] [AMDGPU] Recognise bitmask operations as srcmods on select (PR #152119)
Chris Jackson via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 6 08:11:52 PDT 2025
================
@@ -3036,6 +3036,42 @@ bool AMDGPUDAGToDAGISel::SelectVOP3ModsImpl(SDValue In, SDValue &Src,
Src = Src.getOperand(0);
}
+ // Convert various sign-bit masks on integers to src mods. Currently disabled
+ // for 16-bit types as the codegen replaces the operand without adding a
+ // srcmod. This is intentionally finding the cases where we are performing
+ // float neg and abs on int types, the goal is not to obtain two's complement
+ // neg or abs. Limit converison to select operands via the nonCanonalizing
+ // pattern.
+ // TODO: Add 16-bit support.
+ if (IsCanonicalizing)
+ return true;
+
+ unsigned Opc = Src->getOpcode();
+ EVT VT = Src.getValueType();
+ if ((Opc != ISD::AND && Opc != ISD::OR && Opc != ISD::XOR) ||
+ (VT != MVT::i32 && VT != MVT::v2i32 && VT != MVT::i64))
----------------
chrisjbris wrote:
Ah yes, v2i32 isn't required for now, the parent PR https://github.com/llvm/llvm-project/pull/140694 will legalize v2i32 xor/or/and, so this condition can wait for that.
https://github.com/llvm/llvm-project/pull/152119
More information about the llvm-commits
mailing list