[llvm] [Object] Parsing and dumping of SFrame Frame Row Entries (PR #151301)
Pavel Labath via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 6 01:56:38 PDT 2025
================
@@ -100,6 +111,116 @@ uint64_t SFrameParser<E>::getAbsoluteStartAddress(
return Result;
}
+template <typename EndianT>
+static Error readArray(ArrayRef<uint8_t> Data, uint64_t Count, uint64_t &Offset,
----------------
labath wrote:
Mainly because it simplifies the caller, which would otherwise need to unpack the Expected and copy/move the value into the larger object. I wouldn't do that for a public interface, but these functions are essentially an implementation detail of `FallibleFREIterator::inc()`, so I thought that would be okay.
I can that if you feel strongly about it, but I think version looks better.
https://github.com/llvm/llvm-project/pull/151301
More information about the llvm-commits
mailing list