[llvm] [SPIRV] Fix code quality issues. (PR #152005)

Marcos Maronas via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 5 09:08:44 PDT 2025


================
@@ -73,7 +73,12 @@ class ConvergenceRegion {
         Entry(std::move(CR.Entry)), Exits(std::move(CR.Exits)),
         Blocks(std::move(CR.Blocks)) {}
 
+  // Destructor.
+  ~ConvergenceRegion() { releaseMemory(); }
----------------
maarquitos14 wrote:

I said "likely" because I don't have evidence. I just though that, if there is a `releaseMemory()` method, it should be called in the destructor, as it's done for `ConvergenceRegionInfo` destructor. Happy to remove it if you think it's redundant.

https://github.com/llvm/llvm-project/pull/152005


More information about the llvm-commits mailing list