[llvm] [SPIRV] Fix code quality issues. (PR #152005)

[Marcos Maronas via llvm-commits]

================
@@ -463,8 +463,9 @@ std::string getOclOrSpirvBuiltinDemangledName(StringRef Name) {
     DemangledNameLenStart = NameSpaceStart + 11;
   }
   Start = Name.find_first_not_of("0123456789", DemangledNameLenStart);
-  Name.substr(DemangledNameLenStart, Start - DemangledNameLenStart)
-      .getAsInteger(10, Len);
+  bool Error = Name.substr(DemangledNameLenStart, Start - DemangledNameLenStart)
+                   .getAsInteger(10, Len);
+  assert(!Error && "Failed to parse demangled name length");
----------------
maarquitos14 wrote:

Thanks for the catch! 

https://github.com/llvm/llvm-project/pull/152005