[llvm] ARM: Remove check for isAAPCS_ABI when enabling various aeabi calls (PR #152108)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 5 02:43:25 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-arm
Author: Matt Arsenault (arsenm)
<details>
<summary>Changes</summary>
Based on computeDefaultTargetABI, this appears to be redundant.
The only test using the explicit -target-abi flag with a value different
than one implied by the triple (i.e. assert(TM.isAAPCS_ABI()) under
the condition) is arm-abi-attr.ll and it doesn't stress the libcalls
used.
---
Full diff: https://github.com/llvm/llvm-project/pull/152108.diff
1 Files Affected:
- (modified) llvm/lib/Target/ARM/ARMISelLowering.cpp (+2-2)
``````````diff
diff --git a/llvm/lib/Target/ARM/ARMISelLowering.cpp b/llvm/lib/Target/ARM/ARMISelLowering.cpp
index 7f8b4460bb814..a621e5c63eb07 100644
--- a/llvm/lib/Target/ARM/ARMISelLowering.cpp
+++ b/llvm/lib/Target/ARM/ARMISelLowering.cpp
@@ -588,8 +588,8 @@ ARMTargetLowering::ARMTargetLowering(const TargetMachine &TM_,
}
// RTLIB
- if (TM.isAAPCS_ABI() && (TT.isTargetAEABI() || TT.isTargetGNUAEABI() ||
- TT.isTargetMuslAEABI() || TT.isAndroid())) {
+ if (TT.isTargetAEABI() || TT.isTargetGNUAEABI() || TT.isTargetMuslAEABI() ||
+ TT.isAndroid()) {
// FIXME: This does not depend on the subtarget and should go directly into
// RuntimeLibcalls. This is only here because of missing support for setting
// the calling convention of an implementation.
``````````
</details>
https://github.com/llvm/llvm-project/pull/152108
More information about the llvm-commits
mailing list