[llvm] 888d3cd - MCSymbolGOFF: Remove classof

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2025-08-03T18:31:39-07:00
New Revision: 888d3cde3a1cc742ec5d8483c2f518c9637becbb

URL: https://github.com/llvm/llvm-project/commit/888d3cde3a1cc742ec5d8483c2f518c9637becbb
DIFF: https://github.com/llvm/llvm-project/commit/888d3cde3a1cc742ec5d8483c2f518c9637becbb.diff

LOG: MCSymbolGOFF: Remove classof

The object file format specific derived classes are used in context
where the type is statically known. We don't use isa/dyn_cast and we
want to eliminate MCSymbol::Kind in the base class.

Added: 
    

Modified: 
    llvm/include/llvm/MC/MCSymbolGOFF.h
    llvm/lib/MC/GOFFObjectWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/MC/MCSymbolGOFF.h b/llvm/include/llvm/MC/MCSymbolGOFF.h
index d8c570d2de240..6577747d52c7b 100644
--- a/llvm/include/llvm/MC/MCSymbolGOFF.h
+++ b/llvm/include/llvm/MC/MCSymbolGOFF.h
@@ -47,8 +47,6 @@ class MCSymbolGOFF : public MCSymbol {
     AssociatedDataArea->RequiresNonZeroLength = true;
   }
   MCSectionGOFF *getADA() const { return ADA; }
-
-  static bool classof(const MCSymbol *S) { return S->isGOFF(); }
 };
 } // end namespace llvm
 

diff  --git a/llvm/lib/MC/GOFFObjectWriter.cpp b/llvm/lib/MC/GOFFObjectWriter.cpp
index 88188f34e96fc..3b629cdb87fc1 100644
--- a/llvm/lib/MC/GOFFObjectWriter.cpp
+++ b/llvm/lib/MC/GOFFObjectWriter.cpp
@@ -345,7 +345,7 @@ void GOFFWriter::defineSymbols() {
   for (const MCSymbol &Sym : Asm.symbols()) {
     if (Sym.isTemporary())
       continue;
-    auto &Symbol = cast<MCSymbolGOFF>(Sym);
+    auto &Symbol = static_cast<const MCSymbolGOFF &>(Sym);
     if (Symbol.hasLDAttributes()) {
       Symbol.setIndex(++Ordinal);
       defineLabel(Symbol);