[llvm] [win][arm64ec] Handle `available_externally` functions (PR #151610)
Daniel Paoliello via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 31 15:47:41 PDT 2025
https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/151610
While testing Arm64EC, I observed that LLVM crashes when an `available_externally` function is used as it tries to place it in a COMDAT, which is not permitted by the verifier.
This the fix from #151409 plus a dedicated test.
>From 1364490c1f3c900dba8eb56600925627732a343d Mon Sep 17 00:00:00 2001
From: Daniel Paoliello <danpao at microsoft.com>
Date: Thu, 31 Jul 2025 15:45:35 -0700
Subject: [PATCH] [win][arm64ec] Handle 'externally available' functions
---
llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp | 2 +-
.../test/CodeGen/AArch64/arm64ec-available-externally.ll | 9 +++++++++
2 files changed, 10 insertions(+), 1 deletion(-)
create mode 100644 llvm/test/CodeGen/AArch64/arm64ec-available-externally.ll
diff --git a/llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp b/llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp
index 509cbb092705d..8390c1f291365 100644
--- a/llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp
+++ b/llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp
@@ -872,7 +872,7 @@ bool AArch64Arm64ECCallLowering::runOnModule(Module &Mod) {
if (!F.isDeclaration() && (!F.hasLocalLinkage() || F.hasAddressTaken()) &&
F.getCallingConv() != CallingConv::ARM64EC_Thunk_Native &&
F.getCallingConv() != CallingConv::ARM64EC_Thunk_X64) {
- if (!F.hasComdat())
+ if (!F.hasComdat() && !F.isDeclarationForLinker())
F.setComdat(Mod.getOrInsertComdat(F.getName()));
ThunkMapping.push_back(
{&F, buildEntryThunk(&F), Arm64ECThunkType::Entry});
diff --git a/llvm/test/CodeGen/AArch64/arm64ec-available-externally.ll b/llvm/test/CodeGen/AArch64/arm64ec-available-externally.ll
new file mode 100644
index 0000000000000..9457302403d4c
--- /dev/null
+++ b/llvm/test/CodeGen/AArch64/arm64ec-available-externally.ll
@@ -0,0 +1,9 @@
+; RUN: llc -mtriple arm64ec-windows-msvc < %s
+
+; Arm64EC Regression Test: The Arm64EC Call Lowering was placing "available
+; externally" items in COMDATs, which is not permitted by the module verifier.
+
+define available_externally i32 @f() {
+entry:
+ ret i32 0
+}
More information about the llvm-commits
mailing list