[llvm] [lit] Optionally exclude xfail tests (PR #151191)

Joel E. Denny via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 31 10:44:50 PDT 2025


================
@@ -303,6 +303,12 @@ def parse_args():
         help="do not XFAIL tests with paths in the semicolon separated list",
         default=os.environ.get("LIT_XFAIL_NOT", ""),
     )
+    selection_group.add_argument(
----------------
jdenny-ornl wrote:

`Test.isExpectedToFail` comments say some test formats do not compute xfails until the test is executed (I guess those test formats don't call `parseIntegratedTestScript`).  I believe it is true that `--exclude-xfail` will simply have no effect on those test formats until their maintainers extend them to support it.  In that case, I don't think we need to fix this, but I feel like it ought to be documented somewhere, at the very least in python comments right here where `--exclude-xfail` is parsed.  Maybe: "This option is implemented in lit.TestRunner.parseIntegratedTestScript and so will have no effect on test formats that do not call that and do not implement the option separately."

https://github.com/llvm/llvm-project/pull/151191


More information about the llvm-commits mailing list