[llvm] [SPIRV] Do not use OpTypeRuntimeArray in Kernel env. (PR #149522)
Marcos Maronas via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 30 00:49:15 PDT 2025
================
@@ -1,4 +1,4 @@
-; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefix=SPV
+; RUN: llc -O0 -mtriple=spirv32-unknown-vulkan %s -o - | FileCheck %s --check-prefix=SPV
----------------
maarquitos14 wrote:
Simple Memory model requires Shader capabilities.
Apart from that, we discussed in the past about physical/logical directly implying Kernel/Shader: although de facto you're right --physical is Kernel, logical is Shader--, that is not explicitly specified in the spec, and nothing prevents physical to be used with Shader and logical with Kernel. Also, as far as I know, Addresses doesn't require Kernel.
That being said, I don't think this test was meaning to test Simple memory model, but simply OpMemoryModel, so I see two options:
1. Change the test to use OpenCL rather than Simple, and go back to the old triple.
2. Change the triple to spirv-unknown-vulkan and keep Simple.
I'm happy with either.
https://github.com/llvm/llvm-project/pull/149522
More information about the llvm-commits
mailing list