[llvm] [BOLT][AArch64] Compensate for missing code markers (PR #151060)

Maksim Panchenko via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 29 12:00:28 PDT 2025


maksfb wrote:

Thanks for reviews.

> BTW, before applying your patch, I though BOLT would present an error when encountering code that was missing a marker, but that isn't the case with the added test?

I haven't seen the error regarding the missing marker. In my case, the error came later from JITLink after a chain of events caused by treating code as data.

> AFAIU, the error is ultimately on the source code side (the JIT's codegen). So I am wondering whether colleagues would prefer to guard this behaviour behind a flag as a way of encouraging fixes to those projects. I'll follow-up if that's the case.

Lua JIT has its own assembler and most likely it's the cause of the missing marker. On the BOLT side, if we refactor the code that prints user messages, we can have something like `-Werror` option.

https://github.com/llvm/llvm-project/pull/151060


More information about the llvm-commits mailing list