[llvm] [DirectX] Error handling improve in root signature metadata Parser (PR #149232)

Chris B via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 28 11:47:54 PDT 2025


================
@@ -26,6 +28,80 @@ class Metadata;
 namespace hlsl {
 namespace rootsig {
 
+template <typename T>
+class RootSignatureValidationError
+    : public ErrorInfo<RootSignatureValidationError<T>> {
+public:
+  static char ID;
+  std::string ParamName;
+  T Value;
+
+  RootSignatureValidationError(StringRef ParamName, T Value)
+      : ParamName(ParamName.str()), Value(Value) {}
----------------
llvm-beanz wrote:

Don't need to make a string here.
```suggestion
      : ParamName(ParamName), Value(Value) {}
```

https://github.com/llvm/llvm-project/pull/149232


More information about the llvm-commits mailing list