[compiler-rt] [TSan][compiler-rt] Move symbolization in ReportRace outside of locks on Apple platforms (PR #149516)
Thurston Dang via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 28 11:08:55 PDT 2025
thurstond wrote:
>From the patch title, I was expecting this to be NFC-ish on non-Apple platforms, but IIUC this pull request contains two changes:
1) NFC-ish: for all platforms, defer symbolization (store stack ID etc. instead of symbolized equivalent; then call SymbolizeStackElems() as needed)
2) Apple-specific changes to release locks
Could you please split this into two separate patches? It's much easier to reason about the changes when they are in separate NFC-ish and `#if SANITIZER_APPLE` patches.
https://github.com/llvm/llvm-project/pull/149516
More information about the llvm-commits
mailing list