[llvm] [AMDGPU] introduce S_WAITCNT_LDS_DIRECT in the memory legalizer (PR #150887)

[Sameer Sahasrabuddhe via llvm-commits]

================
@@ -1621,6 +1621,13 @@ let OtherPredicates = [HasImageInsts] in {
   def S_WAIT_KMCNT_soft : SOPP_Pseudo <"s_soft_wait_kmcnt", (ins s16imm:$simm16), "$simm16">;
 }
 
+// Represents the point at which a wave must wait for all outstanding direct loads to LDS.
+// Typically inserted by the memory legalizer and consumed by SIInsertWaitcnts.
+
+def S_WAITCNT_LDS_DIRECT : SPseudoInstSI<(outs), (ins)> {
----------------
ssahasra wrote:

Yeah, I have a great deal of uncertainty on what this pseudo should be called. It seems the "_soft" suffix signifies a definite wait count argument, which the SIInsertWaitcnts pass is allowed to relax. Are you suggesting "S_WAITCNT_lds_direct"? Because "_direct" as a suffix doesn't contain enough information, and there is no "S_WAITCNT_LDS".

https://github.com/llvm/llvm-project/pull/150887