[llvm] [SampleFDO][TypeProf]Support vtable type profiling for ext-binary and text format (PR #148002)

Paschalis Mpeis via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 25 03:01:06 PDT 2025


================
@@ -671,7 +761,7 @@ SampleProfileReaderBinary::readProfile(FunctionSamples &FProfile) {
       return EC;
   }
 
-  return sampleprof_error::success;
+  return readCallsiteVTableProf(FProfile);
----------------
paschalis-mpeis wrote:

nit: Maybe it is more idiomatic and extensible to keep `return success`, after reading any additional profiles based on flags?

```cpp
  if (ReadVTableProf)
     return readCallsiteVTableProf(FProfile);
    
return sampleprof_error::success;    
```

(if this recommendation is applied, there's a similar example in `SampleProfWriter`)

https://github.com/llvm/llvm-project/pull/148002


More information about the llvm-commits mailing list