[lld] [lld][ELF] Introduce an option to keep data section prefix. (PR #148985)
Mingming Liu via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 23 12:24:37 PDT 2025
================
@@ -0,0 +1,127 @@
+# REQUIRES: x86
----------------
mingmingl-llvm wrote:
> From a patch organization perspective, it would be clearer to first introduce the option in a patch and then add RELRO semantics in a follow-up patch (#148920). While it's unusual that 148920 was merged first, the changes remain on the right track...
I appreciate you bringing up the merge order and agree with it. I've opted to merge #148920 first because linker script is an alternative option to this patch, and #148920 is on the common path of either linker script or section grouping.
I'll also follow up on the reviews to get this one ready asap.
> I would rename this to keep-data-section-prefix.s, not introducing a separate test file.
Done.
https://github.com/llvm/llvm-project/pull/148985
More information about the llvm-commits
mailing list