[llvm] [AMDGPU] Generate waterfall for calls with SGPR(inreg) argument (PR #146997)

[Shilei Tian via llvm-commits]

================
@@ -7331,6 +7367,14 @@ void SIInstrInfo::moveToVALU(SIInstrWorklist &Worklist,
     assert(Worklist.empty() &&
            "Deferred MachineInstr are not supposed to re-populate worklist");
   }
+
+  for (auto &Entry : Worklist.WaterFalls) {
+    createWaterFall(Entry.first, MDT, Entry.second.MOs, Entry.second.SGPRs);
+  }
----------------
shiltian wrote:

```suggestion
  for (auto &Entry : Worklist.WaterFalls)
    createWaterFall(Entry.first, MDT, Entry.second.MOs, Entry.second.SGPRs);
```

Use structure binding instead.

https://github.com/llvm/llvm-project/pull/146997