[llvm] [TableGen] Improve handling for dag op names (PR #149248)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 22 23:00:02 PDT 2025


================
@@ -1310,7 +1319,7 @@ const Init *BinOpInit::Fold(const Record *CurRec) const {
       SmallVector<std::pair<const Init *, const StringInit *>, 8> Args;
       llvm::append_range(Args, LHSs->getArgAndNames());
       llvm::append_range(Args, RHSs->getArgAndNames());
-      return DagInit::get(Op, Args);
+      return DagInit::get(Op, LHSs->getName(), Args);
----------------
jurahul wrote:

I think that might be better. Use lhs name if it's not empty else use rhs name. When both names exist, we have a choice of just using lhs, or using lhs if it matches rhs else concat the names with some delimiter. But just something simple like lhs or rhs name seems reasonable.

https://github.com/llvm/llvm-project/pull/149248


More information about the llvm-commits mailing list