[llvm] [PassInstrumentation] Make getPassNameForClassName return optional (PR #150029)

Danila Malyutin via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 22 08:59:49 PDT 2025


================
@@ -33,7 +34,10 @@ PassInstrumentationCallbacks::getPassNameForClassName(StringRef ClassName) {
       Fn();
     ClassToPassNameCallbacks.clear();
   }
-  return ClassToPassName[ClassName];
+  auto PassNameIter = ClassToPassName.find(ClassName);
+  if (PassNameIter != ClassToPassName.end())
+    return PassNameIter->second;
+  return {};
----------------
danilaml wrote:

Isn't `StringRef()` different from `StringRef("")`? They'd compare the same, but go through different constructors (no need to check and store the string literal). Not that it'd matter, but at least in other places `{}` is used so I'd go for consistency.

https://github.com/llvm/llvm-project/pull/150029


More information about the llvm-commits mailing list