[compiler-rt] [compiler-rt] Fix frame numbering for unparsable frames. (PR #148278)

David Justo via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 21 10:23:26 PDT 2025


================
@@ -779,9 +788,13 @@ def __str__(self):
             arch=self.arch,
             start_addr=self.start_addr,
             end_addr=self.end_addr,
-            module_path=self.module_path
-            if self.module_path == self.module_path_for_symbolization
-            else "{} ({})".format(self.module_path_for_symbolization, self.module_path),
+            module_path=(
+                self.module_path
+                if self.module_path == self.module_path_for_symbolization
+                else "{} ({})".format(
+                    self.module_path_for_symbolization, self.module_path
+                )
+            ),
----------------
davidmrdavid wrote:

just checking - there's no change here, just formatting, right?
Was this intended or applied by some kind of auto-formatter? Just wondering if we should minimize the diff by reverting this.

As an aside - this assignment to `module_path` is moderately complex. I wonder if we could make it simpler by expanding the ternary expression into a proper `if-else` block. But that's probably out of scope.

https://github.com/llvm/llvm-project/pull/148278


More information about the llvm-commits mailing list