[llvm] [Object] Parsing and dumping of SFrame FDEs (PR #149828)

via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 21 07:52:13 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/BinaryFormat/SFrame.h llvm/include/llvm/Object/SFrameParser.h llvm/lib/BinaryFormat/SFrame.cpp llvm/lib/Object/SFrameParser.cpp llvm/tools/llvm-readobj/ELFDumper.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/Object/SFrameParser.h b/llvm/include/llvm/Object/SFrameParser.h
index 974c75741..c55cf8198 100644
--- a/llvm/include/llvm/Object/SFrameParser.h
+++ b/llvm/include/llvm/Object/SFrameParser.h
@@ -46,10 +46,13 @@ private:
   uint64_t SectionAddress;
   const sframe::Header<E> &Header;
 
-  SFrameParser(ArrayRef<uint8_t> Data, uint64_t SectionAddress, const sframe::Header<E> &Header)
+  SFrameParser(ArrayRef<uint8_t> Data, uint64_t SectionAddress,
+               const sframe::Header<E> &Header)
       : Data(Data), SectionAddress(SectionAddress), Header(Header) {}
 
-  uint64_t getFDEBegin() const { return sizeof(Header) + Header.AuxHdrLen + Header.FDEOff; }
+  uint64_t getFDEBegin() const {
+    return sizeof(Header) + Header.AuxHdrLen + Header.FDEOff;
+  }
 };
 
 extern template class SFrameParser<endianness::big>;
diff --git a/llvm/lib/Object/SFrameParser.cpp b/llvm/lib/Object/SFrameParser.cpp
index aa3c481d3..fbe35d6d8 100644
--- a/llvm/lib/Object/SFrameParser.cpp
+++ b/llvm/lib/Object/SFrameParser.cpp
@@ -41,7 +41,8 @@ static Expected<const T &> getDataSliceAs(ArrayRef<uint8_t> Data,
 }
 
 template <endianness E>
-Expected<SFrameParser<E>> SFrameParser<E>::create(ArrayRef<uint8_t> Contents, uint64_t SectionAddress) {
+Expected<SFrameParser<E>> SFrameParser<E>::create(ArrayRef<uint8_t> Contents,
+                                                  uint64_t SectionAddress) {
   Expected<const sframe::Preamble<E> &> Preamble =
       getDataSliceAs<sframe::Preamble<E>>(Contents, 0);
   if (!Preamble)
@@ -62,13 +63,12 @@ Expected<SFrameParser<E>> SFrameParser<E>::create(ArrayRef<uint8_t> Contents, ui
   return SFrameParser(Contents, SectionAddress, *Header);
 }
 
-
-template<endianness E>
+template <endianness E>
 Expected<ArrayRef<uint8_t>> SFrameParser<E>::getAuxHeader() const {
   return getDataSlice(Data, sizeof(Header), Header.AuxHdrLen);
 }
 
-template<endianness E>
+template <endianness E>
 Expected<ArrayRef<sframe::FuncDescEntry<E>>> SFrameParser<E>::fdes() const {
   Expected<ArrayRef<uint8_t>> Slice = getDataSlice(
       Data, getFDEBegin(), Header.NumFDEs * sizeof(sframe::FuncDescEntry<E>));
@@ -79,8 +79,9 @@ Expected<ArrayRef<sframe::FuncDescEntry<E>>> SFrameParser<E>::fdes() const {
       Header.NumFDEs);
 }
 
-template<endianness E>
-uint64_t SFrameParser<E>::getAbsoluteStartAddress(typename FDERange::iterator FDE) const {
+template <endianness E>
+uint64_t SFrameParser<E>::getAbsoluteStartAddress(
+    typename FDERange::iterator FDE) const {
   uint64_t Result = SectionAddress + FDE->StartAddress;
 
   if ((getPreamble().Flags.value() & sframe::Flags::FDEFuncStartPCRel) ==

``````````

</details>


https://github.com/llvm/llvm-project/pull/149828


More information about the llvm-commits mailing list