jmorse wrote: This broadly LGTM; it'd be great if someone with more context looks at it too. (The empty-string versus "\n" ambiguity is awkward; but it's also explicit in the spec, so presumably there's a reason for doing it). https://github.com/llvm/llvm-project/pull/149226