[llvm] [TableGen] Add `getName()` to error messages for better debugging (PR #149531)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 18 08:26:04 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-tablegen
Author: Shaoce SUN (sunshaoce)
<details>
<summary>Changes</summary>
Including the name helps quickly locate the corresponding Instruction that caused the issue.
---
Full diff: https://github.com/llvm/llvm-project/pull/149531.diff
1 Files Affected:
- (modified) llvm/utils/TableGen/Common/CodeGenSchedule.cpp (+4-2)
``````````diff
diff --git a/llvm/utils/TableGen/Common/CodeGenSchedule.cpp b/llvm/utils/TableGen/Common/CodeGenSchedule.cpp
index 50346c29e8862..b07ea9e9d5caf 100644
--- a/llvm/utils/TableGen/Common/CodeGenSchedule.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenSchedule.cpp
@@ -2114,7 +2114,8 @@ void CodeGenSchedModels::addWriteRes(const Record *ProcWriteResDef,
const Record *WRDef = ProcWriteResDef->getValueAsDef("WriteType");
if (!WRMap.try_emplace(WRDef, ProcWriteResDef).second)
PrintFatalError(ProcWriteResDef->getLoc(),
- "WriteType already used in another WriteRes");
+ "WriteType of " + WRDef->getName() +
+ " already used in another WriteRes");
}
// Visit ProcResourceKinds referenced by the newly discovered WriteRes.
@@ -2148,7 +2149,8 @@ void CodeGenSchedModels::addReadAdvance(const Record *ProcReadAdvanceDef,
const Record *RADef = ProcReadAdvanceDef->getValueAsDef("ReadType");
if (!RAMap.try_emplace(RADef, ProcReadAdvanceDef).second)
PrintFatalError(ProcReadAdvanceDef->getLoc(),
- "ReadType already used in another ReadAdvance");
+ "ReadType of " + RADef->getName() +
+ " already used in another ReadAdvance");
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/149531
More information about the llvm-commits
mailing list