[llvm] [Offload] Disable failing checks (PR #149283)
Kenneth Benzie via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 17 03:55:44 PDT 2025
https://github.com/kbenzie created https://github.com/llvm/llvm-project/pull/149283
* x86_64-unknown-linux-gnu checks tested on a system with AMD Ryzen 3950X.
* amdgcn-amd-amdhsa checks tested on a system with AMD Radeon 6700XT using ROCm 6.3.
* nvptx64-nvidia-cuda checks tested on a system with NVIDIA RTX 3060 Ti using
* CUDA 12.8.
* Use XFAIL for checks which are always failing
* Use UNSUPPORTED for checks which are flaky
>From d6dee2981ad32fa69779ca63d283ef73b366a4de Mon Sep 17 00:00:00 2001
From: "Kenneth Benzie (Benie)" <k.benzie83 at gmail.com>
Date: Thu, 17 Jul 2025 11:30:46 +0100
Subject: [PATCH 1/3] [Offload] Disable failing nvptx-nvidia-cuda checks
* Use XFAIL for checks which are always failing
* Use UNSUPPORTED for checks which are flaky
Tested on a system with NVIDIA RTX 3060 Ti using CUDA 12.8.
---
offload/test/mapping/map_both_pointer_pointee.c | 1 +
offload/test/offloading/CUDA/basic_launch_multi_arg.cu | 2 ++
offload/test/offloading/bug51781.c | 3 +++
offload/test/offloading/ompx_saxpy_mixed.c | 4 ++++
offload/test/offloading/single_threaded_for_barrier_hang_1.c | 4 ++++
offload/test/offloading/single_threaded_for_barrier_hang_2.c | 2 ++
offload/test/sanitizer/ptr_outside_alloc_1.c | 2 ++
offload/test/sanitizer/ptr_outside_alloc_2.c | 2 ++
offload/test/sanitizer/use_after_free_1.c | 2 ++
offload/test/sanitizer/use_after_free_2.c | 2 ++
offload/test/unified_shared_memory/api.c | 4 ++--
offload/test/unified_shared_memory/close_enter_exit.c | 4 ++--
12 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/offload/test/mapping/map_both_pointer_pointee.c b/offload/test/mapping/map_both_pointer_pointee.c
index 7be1ba465e7db..97a5a93c0502a 100644
--- a/offload/test/mapping/map_both_pointer_pointee.c
+++ b/offload/test/mapping/map_both_pointer_pointee.c
@@ -6,6 +6,7 @@
// REQUIRES: unified_shared_memory
// UNSUPPORTED: amdgcn-amd-amdhsa
+// XFAIL: nvptx64-nvidia-cuda
#pragma omp declare target
int *ptr1;
diff --git a/offload/test/offloading/CUDA/basic_launch_multi_arg.cu b/offload/test/offloading/CUDA/basic_launch_multi_arg.cu
index 1f84a0e1288d4..defcac98d4df1 100644
--- a/offload/test/offloading/CUDA/basic_launch_multi_arg.cu
+++ b/offload/test/offloading/CUDA/basic_launch_multi_arg.cu
@@ -9,6 +9,8 @@
// UNSUPPORTED: aarch64-unknown-linux-gnu-LTO
// UNSUPPORTED: x86_64-unknown-linux-gnu
// UNSUPPORTED: x86_64-unknown-linux-gnu-LTO
+// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda-LTO
#include <stdio.h>
diff --git a/offload/test/offloading/bug51781.c b/offload/test/offloading/bug51781.c
index 2f30b035afbbe..49985f4d0ca43 100644
--- a/offload/test/offloading/bug51781.c
+++ b/offload/test/offloading/bug51781.c
@@ -32,6 +32,9 @@
//
// CUSTOM: Rewriting generic-mode kernel with a customized state machine.
+// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda-LTO
+
#if ADD_REDUCTION
#define REDUCTION(...) reduction(__VA_ARGS__)
#else
diff --git a/offload/test/offloading/ompx_saxpy_mixed.c b/offload/test/offloading/ompx_saxpy_mixed.c
index 02cb78b216b87..420286e9c1e90 100644
--- a/offload/test/offloading/ompx_saxpy_mixed.c
+++ b/offload/test/offloading/ompx_saxpy_mixed.c
@@ -2,6 +2,10 @@
//
// REQUIRES: gpu
+// Test if flaky
+// UNSUPPORTED: nvptx64-nvidia-cuda
+// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
+
#include <math.h>
#include <omp.h>
#include <ompx.h>
diff --git a/offload/test/offloading/single_threaded_for_barrier_hang_1.c b/offload/test/offloading/single_threaded_for_barrier_hang_1.c
index 8ee6b51fb6818..0187530a6e235 100644
--- a/offload/test/offloading/single_threaded_for_barrier_hang_1.c
+++ b/offload/test/offloading/single_threaded_for_barrier_hang_1.c
@@ -1,6 +1,10 @@
// RUN: %libomptarget-compile-run-and-check-generic
// RUN: %libomptarget-compileopt-run-and-check-generic
+// Test causes hangs which stop lit from exiting
+// UNSUPPORTED: nvptx64-nvidia-cuda
+// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
+
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/offloading/single_threaded_for_barrier_hang_2.c b/offload/test/offloading/single_threaded_for_barrier_hang_2.c
index a98abd6922da7..519be6afbe902 100644
--- a/offload/test/offloading/single_threaded_for_barrier_hang_2.c
+++ b/offload/test/offloading/single_threaded_for_barrier_hang_2.c
@@ -1,6 +1,8 @@
// RUN: %libomptarget-compile-run-and-check-generic
// FIXME: This fails with optimization enabled and prints b: 0
// FIXME: RUN: %libomptarget-compileopt-run-and-check-generic
+// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda-LTO
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/sanitizer/ptr_outside_alloc_1.c b/offload/test/sanitizer/ptr_outside_alloc_1.c
index bdd028352e403..0b6664dc3432d 100644
--- a/offload/test/sanitizer/ptr_outside_alloc_1.c
+++ b/offload/test/sanitizer/ptr_outside_alloc_1.c
@@ -11,6 +11,8 @@
// UNSUPPORTED: x86_64-unknown-linux-gnu-LTO
// UNSUPPORTED: s390x-ibm-linux-gnu
// UNSUPPORTED: s390x-ibm-linux-gnu-LTO
+// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda-LTO
#include <omp.h>
diff --git a/offload/test/sanitizer/ptr_outside_alloc_2.c b/offload/test/sanitizer/ptr_outside_alloc_2.c
index 6a67962f9eb32..431dd7f32bfa5 100644
--- a/offload/test/sanitizer/ptr_outside_alloc_2.c
+++ b/offload/test/sanitizer/ptr_outside_alloc_2.c
@@ -9,6 +9,8 @@
// UNSUPPORTED: x86_64-unknown-linux-gnu-LTO
// UNSUPPORTED: s390x-ibm-linux-gnu
// UNSUPPORTED: s390x-ibm-linux-gnu-LTO
+// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda-LTO
#include <omp.h>
diff --git a/offload/test/sanitizer/use_after_free_1.c b/offload/test/sanitizer/use_after_free_1.c
index c4783c5c36df9..2613c50b4b4d6 100644
--- a/offload/test/sanitizer/use_after_free_1.c
+++ b/offload/test/sanitizer/use_after_free_1.c
@@ -11,6 +11,8 @@
// UNSUPPORTED: x86_64-unknown-linux-gnu-LTO
// UNSUPPORTED: s390x-ibm-linux-gnu
// UNSUPPORTED: s390x-ibm-linux-gnu-LTO
+// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda-LTO
#include <omp.h>
diff --git a/offload/test/sanitizer/use_after_free_2.c b/offload/test/sanitizer/use_after_free_2.c
index 02aa453d0a975..daa45329432d8 100644
--- a/offload/test/sanitizer/use_after_free_2.c
+++ b/offload/test/sanitizer/use_after_free_2.c
@@ -9,6 +9,8 @@
// UNSUPPORTED: x86_64-unknown-linux-gnu-LTO
// UNSUPPORTED: s390x-ibm-linux-gnu
// UNSUPPORTED: s390x-ibm-linux-gnu-LTO
+// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda-LTO
#include <omp.h>
diff --git a/offload/test/unified_shared_memory/api.c b/offload/test/unified_shared_memory/api.c
index b938971b4b03c..1673ba7b7f764 100644
--- a/offload/test/unified_shared_memory/api.c
+++ b/offload/test/unified_shared_memory/api.c
@@ -1,8 +1,8 @@
// RUN: %libomptarget-compile-generic
// RUN: env HSA_XNACK=1 \
// RUN: %libomptarget-run-generic | %fcheck-generic
-// XFAIL: nvptx64-nvidia-cuda
-// XFAIL: nvptx64-nvidia-cuda-LTO
+// UNSUPPORTED: nvptx64-nvidia-cuda
+// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
// REQUIRES: unified_shared_memory
diff --git a/offload/test/unified_shared_memory/close_enter_exit.c b/offload/test/unified_shared_memory/close_enter_exit.c
index b116c652f47e9..a8d90ca356b94 100644
--- a/offload/test/unified_shared_memory/close_enter_exit.c
+++ b/offload/test/unified_shared_memory/close_enter_exit.c
@@ -6,8 +6,8 @@
// UNSUPPORTED: clang-6, clang-7, clang-8, clang-9
// Fails on nvptx with error: an illegal memory access was encountered
-// XFAIL: nvptx64-nvidia-cuda
-// XFAIL: nvptx64-nvidia-cuda-LTO
+// UNSUPPORTED: nvptx64-nvidia-cuda
+// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
#include <omp.h>
#include <stdio.h>
>From 299fe8668300127d707e96ca6c4caf5b6149e810 Mon Sep 17 00:00:00 2001
From: "Kenneth Benzie (Benie)" <k.benzie83 at gmail.com>
Date: Thu, 17 Jul 2025 11:37:35 +0100
Subject: [PATCH 2/3] [Offload] Disable failing amdgcn-amd-amdhsa checks
* Use XFAIL for checks which are always failing
Tested on a system with AMD Radeon 6700XT using ROCm 6.3.
---
offload/test/mapping/map_ptr_and_star_global.c | 1 +
offload/test/mapping/map_ptr_and_star_local.c | 1 +
offload/test/mapping/map_ptr_and_subscript_global.c | 1 +
offload/test/mapping/map_ptr_and_subscript_local.c | 1 +
offload/test/mapping/map_structptr_and_member_global.c | 1 +
offload/test/mapping/map_structptr_and_member_local.c | 1 +
offload/test/offloading/CUDA/basic_launch_multi_arg.cu | 1 +
offload/test/offloading/bug51781.c | 1 +
offload/test/offloading/single_threaded_for_barrier_hang_2.c | 1 +
9 files changed, 9 insertions(+)
diff --git a/offload/test/mapping/map_ptr_and_star_global.c b/offload/test/mapping/map_ptr_and_star_global.c
index c3b0dd2f49e6b..a3aa8c502cb34 100644
--- a/offload/test/mapping/map_ptr_and_star_global.c
+++ b/offload/test/mapping/map_ptr_and_star_global.c
@@ -1,4 +1,5 @@
// RUN: %libomptarget-compilexx-run-and-check-generic
+// XFAIL: amdgcn-amd-amdhsa
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/mapping/map_ptr_and_star_local.c b/offload/test/mapping/map_ptr_and_star_local.c
index f0ca84d1cc4dd..21ca4872a67f9 100644
--- a/offload/test/mapping/map_ptr_and_star_local.c
+++ b/offload/test/mapping/map_ptr_and_star_local.c
@@ -1,4 +1,5 @@
// RUN: %libomptarget-compilexx-run-and-check-generic
+// XFAIL: amdgcn-amd-amdhsa
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/mapping/map_ptr_and_subscript_global.c b/offload/test/mapping/map_ptr_and_subscript_global.c
index a3a10b6c9b212..01b5b383b7033 100644
--- a/offload/test/mapping/map_ptr_and_subscript_global.c
+++ b/offload/test/mapping/map_ptr_and_subscript_global.c
@@ -1,4 +1,5 @@
// RUN: %libomptarget-compilexx-run-and-check-generic
+// XFAIL: amdgcn-amd-amdhsa
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/mapping/map_ptr_and_subscript_local.c b/offload/test/mapping/map_ptr_and_subscript_local.c
index bb44999541a7b..29103c13277c5 100644
--- a/offload/test/mapping/map_ptr_and_subscript_local.c
+++ b/offload/test/mapping/map_ptr_and_subscript_local.c
@@ -1,4 +1,5 @@
// RUN: %libomptarget-compilexx-run-and-check-generic
+// XFAIL: amdgcn-amd-amdhsa
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/mapping/map_structptr_and_member_global.c b/offload/test/mapping/map_structptr_and_member_global.c
index 10e72e070dbc5..55b10f21b7df3 100644
--- a/offload/test/mapping/map_structptr_and_member_global.c
+++ b/offload/test/mapping/map_structptr_and_member_global.c
@@ -1,4 +1,5 @@
// RUN: %libomptarget-compilexx-run-and-check-generic
+// XFAIL: amdgcn-amd-amdhsa
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/mapping/map_structptr_and_member_local.c b/offload/test/mapping/map_structptr_and_member_local.c
index 9e59551ad3d6c..4370d5700635f 100644
--- a/offload/test/mapping/map_structptr_and_member_local.c
+++ b/offload/test/mapping/map_structptr_and_member_local.c
@@ -1,4 +1,5 @@
// RUN: %libomptarget-compilexx-run-and-check-generic
+// XFAIL: amdgcn-amd-amdhsa
#include <omp.h>
#include <stdio.h>
diff --git a/offload/test/offloading/CUDA/basic_launch_multi_arg.cu b/offload/test/offloading/CUDA/basic_launch_multi_arg.cu
index defcac98d4df1..c6dc919f1f24d 100644
--- a/offload/test/offloading/CUDA/basic_launch_multi_arg.cu
+++ b/offload/test/offloading/CUDA/basic_launch_multi_arg.cu
@@ -9,6 +9,7 @@
// UNSUPPORTED: aarch64-unknown-linux-gnu-LTO
// UNSUPPORTED: x86_64-unknown-linux-gnu
// UNSUPPORTED: x86_64-unknown-linux-gnu-LTO
+// XFAIL: amdgcn-amd-amdhsa
// XFAIL: nvptx64-nvidia-cuda
// XFAIL: nvptx64-nvidia-cuda-LTO
diff --git a/offload/test/offloading/bug51781.c b/offload/test/offloading/bug51781.c
index 49985f4d0ca43..9c86120c1d12a 100644
--- a/offload/test/offloading/bug51781.c
+++ b/offload/test/offloading/bug51781.c
@@ -32,6 +32,7 @@
//
// CUSTOM: Rewriting generic-mode kernel with a customized state machine.
+// XFAIL: amdgcn-amd-amdhsa
// XFAIL: nvptx64-nvidia-cuda
// XFAIL: nvptx64-nvidia-cuda-LTO
diff --git a/offload/test/offloading/single_threaded_for_barrier_hang_2.c b/offload/test/offloading/single_threaded_for_barrier_hang_2.c
index 519be6afbe902..9620aa5ec957e 100644
--- a/offload/test/offloading/single_threaded_for_barrier_hang_2.c
+++ b/offload/test/offloading/single_threaded_for_barrier_hang_2.c
@@ -1,6 +1,7 @@
// RUN: %libomptarget-compile-run-and-check-generic
// FIXME: This fails with optimization enabled and prints b: 0
// FIXME: RUN: %libomptarget-compileopt-run-and-check-generic
+// XFAIL: amdgcn-amd-amdhsa
// XFAIL: nvptx64-nvidia-cuda
// XFAIL: nvptx64-nvidia-cuda-LTO
>From e5f85f82de3521073e58d233933471eb34afa868 Mon Sep 17 00:00:00 2001
From: "Kenneth Benzie (Benie)" <k.benzie83 at gmail.com>
Date: Thu, 17 Jul 2025 11:52:02 +0100
Subject: [PATCH 3/3] [Offload] Disable failing x86_64-unknown-linux-gpu checks
* Use XFAIL for checks which are always failing
Tested on a system with AMD Ryzen 3950X.
---
offload/test/offloading/bug51781.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/offload/test/offloading/bug51781.c b/offload/test/offloading/bug51781.c
index 9c86120c1d12a..f3f6b53159552 100644
--- a/offload/test/offloading/bug51781.c
+++ b/offload/test/offloading/bug51781.c
@@ -32,6 +32,8 @@
//
// CUSTOM: Rewriting generic-mode kernel with a customized state machine.
+// XFAIL: x86_64-unknown-linux-gnu
+// XFAIL: x86_64-unknown-linux-gnu-LTO
// XFAIL: amdgcn-amd-amdhsa
// XFAIL: nvptx64-nvidia-cuda
// XFAIL: nvptx64-nvidia-cuda-LTO
More information about the llvm-commits
mailing list