[llvm] [GVN][NFC] Use early return in phiTranslateImpl() (PR #149268)
Madhur Amilkanthwar via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 17 00:51:34 PDT 2025
https://github.com/madhur13490 created https://github.com/llvm/llvm-project/pull/149268
None
>From f5952a1d5bc5c3ceefa26690b95fd967e6eb7c54 Mon Sep 17 00:00:00 2001
From: Madhur Amilkanthwar <madhura at nvidia.com>
Date: Wed, 16 Jul 2025 08:26:38 -0700
Subject: [PATCH] [GVN][NFC] Use early return in phiTranslateImpl()
---
llvm/lib/Transforms/Scalar/GVN.cpp | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp
index 8bff458f88bb9..affae41ed2c83 100644
--- a/llvm/lib/Transforms/Scalar/GVN.cpp
+++ b/llvm/lib/Transforms/Scalar/GVN.cpp
@@ -2367,12 +2367,15 @@ uint32_t GVNPass::ValueTable::phiTranslateImpl(const BasicBlock *Pred,
// See if we can refine the value number by looking at the PN incoming value
// for the given predecessor.
if (PHINode *PN = NumberingPhi[Num]) {
- if (PN->getParent() == PhiBlock)
- for (unsigned I = 0; I != PN->getNumIncomingValues(); ++I)
- if (PN->getIncomingBlock(I) == Pred)
- if (uint32_t TransVal = lookup(PN->getIncomingValue(I), false))
- return TransVal;
- return Num;
+ if (PN->getParent() != PhiBlock)
+ return Num;
+
+ for (unsigned I = 0; I != PN->getNumIncomingValues(); ++I) {
+ if (PN->getIncomingBlock(I) != Pred)
+ continue;
+ if (uint32_t TransVal = lookup(PN->getIncomingValue(I), false))
+ return TransVal;
+ }
}
if (BasicBlock *BB = NumberingBB[Num]) {
More information about the llvm-commits
mailing list