[compiler-rt] [sanitizer] Fix libcxx cache existence check in symbolizer build (PR #149249)

via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 16 22:08:22 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: None (int-zjt)

<details>
<summary>Changes</summary>

The script incorrectly checked ${LLVM_BUILD}/build.ninja to determine if cached libcxx is available, while it should be checking the actual libcxx build directory at ${LIBCXX_BUILD}/build.ninja.


---
Full diff: https://github.com/llvm/llvm-project/pull/149249.diff


1 Files Affected:

- (modified) compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh (+1-1) 


``````````diff
diff --git a/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh b/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
index 4d435976d3a10..c16ced067d4df 100755
--- a/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
+++ b/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
@@ -87,7 +87,7 @@ AR="${AR}" CC="${CC}" CFLAGS="$FLAGS -Wno-deprecated-non-prototype" RANLIB=/bin/
 make -j libz.a
 
 # Build and install libcxxabi and libcxx.
-if [[ ! -f ${LLVM_BUILD}/build.ninja ]]; then
+if [[ ! -f ${LIBCXX_BUILD}/build.ninja ]]; then
   rm -rf "${LIBCXX_BUILD}" "${LIBCXX_INSTALL}"
   mkdir -p ${LIBCXX_BUILD} ${LIBCXX_INSTALL}
   cd ${LIBCXX_BUILD}

``````````

</details>


https://github.com/llvm/llvm-project/pull/149249


More information about the llvm-commits mailing list