[llvm] [CodeGen] Remove dead hack for MIPS (PR #148039)

via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 16 09:52:42 PDT 2025


================
@@ -534,9 +534,7 @@ void LiveVariables::runOnInstr(MachineInstr &MI,
         UseRegs.push_back(MOReg);
     } else {
       assert(MO.isDef());
-      // FIXME: We should not remove any dead flags. However the MIPS RDDSP
-      // instruction needs it at the moment: http://llvm.org/PR27116.
-      if (MOReg.isPhysical() && !MRI->isReserved(MOReg))
+      if (!(MOReg.isPhysical() && MRI->isReserved(MOReg)))
----------------
AZero13 wrote:

> The condition should be demorganed. The comment also states that dead flags should not be removed, and this is still removing a dead flag

Fixed!

https://github.com/llvm/llvm-project/pull/148039


More information about the llvm-commits mailing list