[llvm] [SLP][NFC] Avoid the getRdxOperand hack (PR #148672)

Alexey Bataev via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 16 03:08:29 PDT 2025


alexey-bataev wrote:

> > I would keep the original functions. Maybe, do some early checks for index 0 and later checks for index 1, but still keep the existing abstractions.
> 
> The comment says "TODO: Change the code and data structures to handle this without a hack." I'm doing exactly this. How to keep these functions in place and why?



Yes, but you did not fix it, just moved to another place. Instead, would be good just to build the list of operands (actual operands, excluding true value) and just return the corresponding operand without adjusting the index


https://github.com/llvm/llvm-project/pull/148672


More information about the llvm-commits mailing list