[llvm] [Object] Beginnings of SFrame parser and dumper (PR #147294)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 16 03:03:45 PDT 2025


================
@@ -1,14 +1,22 @@
 ## Check parsing and dumping of the SFrame header.
 # RUN: yaml2obj --docnum=1 %s -o %t.1
-# RUN: llvm-readobj --sframe=.sframe_1b --sframe=.sframe_bad_magic \
-# RUN:   --sframe=.sframe_bad_version --sframe=.sframe_6b \
-# RUN:   --sframe=.sframe_header %t.1 2>&1 \
-# RUN: | FileCheck %s --strict-whitespace --match-full-lines --check-prefix=CASE1
+# RUN: llvm-readobj --sframe=.sframe_bad_sh_size --sframe=.sframe_1b \
+# RUN:   --sframe=.sframe_bad_magic --sframe=.sframe_bad_version \
+# RUN:   --sframe=.sframe_6b --sframe=.sframe_header %t.1 2>&1 \
+# RUN: | FileCheck %s --strict-whitespace --match-full-lines \
----------------
jh7370 wrote:

Nit: here and below. The more common style we use in newer llvm-readobj tests is as suggested. The idea being that the `| \` at the end of the first line indicates a new command follows on the next line, while the indentation of the second indicates it's a continuation of a chain from the previous line.
```suggestion
# RUN:   --sframe=.sframe_6b --sframe=.sframe_header %t.1 2>&1 | \
# RUN:   FileCheck %s --strict-whitespace --match-full-lines \
```

https://github.com/llvm/llvm-project/pull/147294


More information about the llvm-commits mailing list