[llvm] [DebugInfo] Remove getPrevNonDebugInstruction (PR #148859)

[Nikita Popov via llvm-commits]

================
@@ -3015,7 +3015,7 @@ bool CodeGenPrepare::dupRetToEnableTailCallOpts(BasicBlock *BB,
         //   %phi = phi ptr [ %0, %bb0 ], [ %2, %entry ]
         if (PredBB && PredBB->getSingleSuccessor() == BB)
           CI = dyn_cast_or_null<CallInst>(
-              PredBB->getTerminator()->getPrevNonDebugInstruction(true));
+              PredBB->getTerminator()->getPrevNonPseudoOpInstruction());
----------------
nikic wrote:

I think the skipping of pseudo probes here is probably not just unnecessary but outright incorrect.

If there is no test coverage for this, replace with getPrevNode() and drop the method please.

https://github.com/llvm/llvm-project/pull/148859