[lld] [llvm] [lld][AArch64][Build Attributes] Add support for AArch64 Build Attributes (PR #147970)
Peter Smith via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 15 06:02:02 PDT 2025
================
@@ -552,8 +591,20 @@ template <class ELFT> void ObjFile<ELFT>::parse(bool ignoreComdats) {
StringRef shstrtab = CHECK2(obj.getSectionStringTable(objSections), this);
uint64_t size = objSections.size();
sections.resize(size);
+
for (size_t i = 0; i != size; ++i) {
const Elf_Shdr &sec = objSections[i];
+ // Read GNU property section into a per-InputFile structure that will be
----------------
smithp35 wrote:
This read of the GNU properties was necessary in SivanShani-Arm's version as BuildAttributes were being processed in parse(). Now that code has been moved to initializeSections() we can rely on initializeSections() to read the GNU properties.
TL;DR I think you should be able to remove this code so that GNU properties are only read once.
https://github.com/llvm/llvm-project/pull/147970
More information about the llvm-commits
mailing list