[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #147342)

Sarah Spall via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 14 11:33:31 PDT 2025


================
@@ -287,6 +287,27 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(const TargetInfo &TI,
     if (CheckAllArgTypesAreCorrect(&SemaRef, TheCall,
                                    llvm::ArrayRef(ChecksArr)))
       return true;
+    // Check that first two arguments are vectors of the same type
----------------
spall wrote:

the first two can be scalars as well; they just need to be the same type. So I'd recommend updating this comment to state as such. 

https://github.com/llvm/llvm-project/pull/147342


More information about the llvm-commits mailing list