[llvm] [Support/BLAKE3] quick fix for Cygwin build (PR #148635)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 14 06:47:19 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Tomohiro Kashiwada (kikairoya)
<details>
<summary>Changes</summary>
BLAKE3 1.8.2 ( imported in d2ad63a193216d008c8161879a59c5f42e0125cc ) fails to build for the Cygwin target.
see: https://github.com/BLAKE3-team/BLAKE3/issues/494
As a temporary workaround, add `&& !defined(__CYGWIN__)` to BLAKE3 locally.
resolves https://github.com/llvm/llvm-project/issues/148365
---
Full diff: https://github.com/llvm/llvm-project/pull/148635.diff
2 Files Affected:
- (modified) llvm/lib/Support/BLAKE3/blake3_dispatch.c (+1-1)
- (modified) llvm/lib/Support/BLAKE3/blake3_impl.h (+1-1)
``````````diff
diff --git a/llvm/lib/Support/BLAKE3/blake3_dispatch.c b/llvm/lib/Support/BLAKE3/blake3_dispatch.c
index d00580fe35195..19918aa708b2f 100644
--- a/llvm/lib/Support/BLAKE3/blake3_dispatch.c
+++ b/llvm/lib/Support/BLAKE3/blake3_dispatch.c
@@ -236,7 +236,7 @@ void blake3_xof_many(const uint32_t cv[8],
#if defined(IS_X86)
const enum cpu_feature features = get_cpu_features();
MAYBE_UNUSED(features);
-#if !defined(_WIN32) && !defined(BLAKE3_NO_AVX512)
+#if !defined(_WIN32) && !defined(__CYGWIN__) && !defined(BLAKE3_NO_AVX512)
if (features & AVX512VL) {
blake3_xof_many_avx512(cv, block, block_len, counter, flags, out, outblocks);
return;
diff --git a/llvm/lib/Support/BLAKE3/blake3_impl.h b/llvm/lib/Support/BLAKE3/blake3_impl.h
index deed079e468a5..dd71e729f208f 100644
--- a/llvm/lib/Support/BLAKE3/blake3_impl.h
+++ b/llvm/lib/Support/BLAKE3/blake3_impl.h
@@ -324,7 +324,7 @@ void blake3_hash_many_avx512(const uint8_t *const *inputs, size_t num_inputs,
uint8_t flags, uint8_t flags_start,
uint8_t flags_end, uint8_t *out);
-#if !defined(_WIN32)
+#if !defined(_WIN32) && !defined(__CYGWIN__)
LLVM_LIBRARY_VISIBILITY
void blake3_xof_many_avx512(const uint32_t cv[8],
const uint8_t block[BLAKE3_BLOCK_LEN],
``````````
</details>
https://github.com/llvm/llvm-project/pull/148635
More information about the llvm-commits
mailing list