[llvm] [NFC] Remove mention of nonexistent SPIR_FUNC restriction. (PR #148625)
Harald van Dijk via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 14 06:02:04 PDT 2025
https://github.com/hvdijk created https://github.com/llvm/llvm-project/pull/148625
The documentation for SPIR_FUNC mentions that functions can only call SPIR_FUNC and SPIR_KERNEL functions, but there is no verification of this and we rely on being able to call functions with the default calling convention at least for intrinsics.
>From be4edddebd45ce151717e4813d5f32acc639b1de Mon Sep 17 00:00:00 2001
From: Harald van Dijk <harald.vandijk at codeplay.com>
Date: Mon, 14 Jul 2025 14:00:54 +0100
Subject: [PATCH] [NFC] Remove mention of nonexistent SPIR_FUNC restriction.
The documentation for SPIR_FUNC mentions that functions can only call
SPIR_FUNC and SPIR_KERNEL functions, but there is no verification of
this and we rely on being able to call functions with the default
calling convention at least for intrinsics.
---
llvm/include/llvm/IR/CallingConv.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/llvm/include/llvm/IR/CallingConv.h b/llvm/include/llvm/IR/CallingConv.h
index d68491eb5535c..d9c67d9f227c1 100644
--- a/llvm/include/llvm/IR/CallingConv.h
+++ b/llvm/include/llvm/IR/CallingConv.h
@@ -130,11 +130,10 @@ namespace CallingConv {
/// Used for SPIR non-kernel device functions. No lowering or expansion of
/// arguments. Structures are passed as a pointer to a struct with the
- /// byval attribute. Functions can only call SPIR_FUNC and SPIR_KERNEL
- /// functions. Functions can only have zero or one return values. Variable
- /// arguments are not allowed, except for printf. How arguments/return
- /// values are lowered are not specified. Functions are only visible to the
- /// devices.
+ /// byval attribute. Functions can only have zero or one return values.
+ /// Variable arguments are not allowed, except for printf. How
+ /// arguments/return values are lowered are not specified. Functions are
+ /// only visible to the devices.
SPIR_FUNC = 75,
/// Used for SPIR kernel functions. Inherits the restrictions of SPIR_FUNC,
More information about the llvm-commits
mailing list