[llvm] [Offload] Make EnumValueRec::getTaggedType() optional (PR #147998)

[Kenneth Benzie via llvm-commits]

https://github.com/kbenzie updated https://github.com/llvm/llvm-project/pull/147998

>From 192a34d8605dfa92760e2252f6224b6c80718bb0 Mon Sep 17 00:00:00 2001
From: "Kenneth Benzie (Benie)" <k.benzie83 at gmail.com>
Date: Thu, 10 Jul 2025 17:33:18 +0100
Subject: [PATCH] [Offload] Make EnumValueRec::getTaggedType() optional

Not all `EnumValue`s specify a tagged type, this patch reflects that in
the record definitions whilst also including the tagged type in the docs
when it is specified.
---
 offload/tools/offload-tblgen/DocGen.cpp      | 6 +++++-
 offload/tools/offload-tblgen/PrintGen.cpp    | 2 +-
 offload/tools/offload-tblgen/RecordTypes.hpp | 4 ++--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/offload/tools/offload-tblgen/DocGen.cpp b/offload/tools/offload-tblgen/DocGen.cpp
index 29d00cb3b5098..c9899f7e72748 100644
--- a/offload/tools/offload-tblgen/DocGen.cpp
+++ b/offload/tools/offload-tblgen/DocGen.cpp
@@ -86,7 +86,11 @@ void processEnum(const EnumRec &E, raw_ostream &OS) {
   for (const EnumValueRec Etor : E.getValues()) {
     OS << formatv("  .. c:enumerator:: {0}_{1}\n\n", E.getEnumValNamePrefix(),
                   Etor.getName());
-    OS << "    " << Etor.getDesc() << "\n\n";
+    OS << "    ";
+    if (Etor.getTaggedType()) {
+      OS << ":c:expr:`" << *Etor.getTaggedType() << "` — ";
+    }
+    OS << Etor.getDesc() << "\n\n";
   }
 }
 
diff --git a/offload/tools/offload-tblgen/PrintGen.cpp b/offload/tools/offload-tblgen/PrintGen.cpp
index 89d7c820426cf..a2a9b628ce483 100644
--- a/offload/tools/offload-tblgen/PrintGen.cpp
+++ b/offload/tools/offload-tblgen/PrintGen.cpp
@@ -82,7 +82,7 @@ inline void printTagged(llvm::raw_ostream &os, const void *ptr, {0} value, size_
             TAB_2 "const {0} * const tptr = (const {0} * const)ptr;\n", Type);
       // TODO: Handle other cases here
       OS << TAB_2 "os << (const void *)tptr << \" (\";\n";
-      if (Type.ends_with("*")) {
+      if (Type->ends_with("*")) {
         OS << TAB_2 "os << printPtr(os, tptr);\n";
       } else {
         OS << TAB_2 "os << *tptr;\n";
diff --git a/offload/tools/offload-tblgen/RecordTypes.hpp b/offload/tools/offload-tblgen/RecordTypes.hpp
index 65c0a4ce4a2c7..c63876bc346da 100644
--- a/offload/tools/offload-tblgen/RecordTypes.hpp
+++ b/offload/tools/offload-tblgen/RecordTypes.hpp
@@ -66,8 +66,8 @@ class EnumValueRec {
   explicit EnumValueRec(const Record *rec) : rec(rec) {}
   std::string getName() const { return rec->getValueAsString("name").upper(); }
   StringRef getDesc() const { return rec->getValueAsString("desc"); }
-  StringRef getTaggedType() const {
-    return rec->getValueAsString("tagged_type");
+  std::optional<StringRef> getTaggedType() const {
+    return rec->getValueAsOptionalString("tagged_type");
   }
 
 private: