[llvm] [CostModel] Handle all cost kinds in getCmpSelInstrCost (PR #148233)

David Green via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 14 01:43:23 PDT 2025


================
@@ -1369,8 +1369,7 @@ class BasicTTIImplBase : public TargetTransformInfoImplCRTPBase<T> {
     int ISD = TLI->InstructionOpcodeToISD(Opcode);
     assert(ISD && "Invalid opcode");
 
-    // TODO: Handle other cost kinds.
-    if (CostKind != TTI::TCK_RecipThroughput)
+    if (getTLI()->getValueType(DL, ValTy, true) == MVT::Other)
----------------
davemgreen wrote:

Hi. IIRC something (maybe simplifycfg) was trying to cost `[2 x i64]` selects. Otherwise this if would have been removed.

https://github.com/llvm/llvm-project/pull/148233


More information about the llvm-commits mailing list