[libc] [llvm] [libc][math] Refactor ldexpf implementation to header-only in src/__support/math folder (PR #147906)
Muhammad Bassiouni via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 12 13:25:13 PDT 2025
https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/147906
>From addec87f0cd595b6dbe30e373c4b4ee80177afc6 Mon Sep 17 00:00:00 2001
From: bassiounix <muhammad.m.bassiouni at gmail.com>
Date: Thu, 10 Jul 2025 09:24:28 +0300
Subject: [PATCH 1/3] [libc][math] Refactor ldexpf128 implementation to
header-only in src/__support/math folder.
---
libc/shared/math.h | 1 +
libc/shared/math/ldexpf128.h | 29 ++++++++++++++++
libc/src/__support/math/CMakeLists.txt | 10 ++++++
libc/src/__support/math/ldexpf128.h | 34 +++++++++++++++++++
libc/src/math/generic/CMakeLists.txt | 3 +-
libc/src/math/generic/ldexpf128.cpp | 7 ++--
.../llvm-project-overlay/libc/BUILD.bazel | 17 +++++++++-
7 files changed, 94 insertions(+), 7 deletions(-)
create mode 100644 libc/shared/math/ldexpf128.h
create mode 100644 libc/src/__support/math/ldexpf128.h
diff --git a/libc/shared/math.h b/libc/shared/math.h
index e2950e075a81d..7ad6b7ecb941f 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -16,5 +16,6 @@
#include "math/frexpf.h"
#include "math/frexpf128.h"
#include "math/frexpf16.h"
+#include "math/ldexpf128.h"
#endif // LLVM_LIBC_SHARED_MATH_H
diff --git a/libc/shared/math/ldexpf128.h b/libc/shared/math/ldexpf128.h
new file mode 100644
index 0000000000000..d4066beb809c7
--- /dev/null
+++ b/libc/shared/math/ldexpf128.h
@@ -0,0 +1,29 @@
+//===-- Shared ldexpf128 function -------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_LDEXPF128_H
+#define LLVM_LIBC_SHARED_MATH_LDEXPF128_H
+
+#include "include/llvm-libc-types/float128.h"
+
+#ifdef LIBC_TYPES_HAS_FLOAT128
+
+#include "shared/libc_common.h"
+#include "src/__support/math/ldexpf128.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::ldexpf128;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LIBC_TYPES_HAS_FLOAT128
+
+#endif // LLVM_LIBC_SHARED_MATH_LDEXPF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 0baf12a26a9d5..4adfc33507e5d 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -82,3 +82,13 @@ add_header_library(
DEPENDS
libc.src.__support.FPUtil.manipulation_functions
)
+
+add_header_library(
+ ldexpf128
+ HDRS
+ ldexpf128.h
+ DEPENDS
+ libc.src.__support.macros.properties.types
+ libc.src.__support.FPUtil.manipulation_functions
+ libc.include.llvm-libc-types.float128
+)
diff --git a/libc/src/__support/math/ldexpf128.h b/libc/src/__support/math/ldexpf128.h
new file mode 100644
index 0000000000000..362583093b2f3
--- /dev/null
+++ b/libc/src/__support/math/ldexpf128.h
@@ -0,0 +1,34 @@
+//===-- Implementation header for ldexpf ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF128_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF128_H
+
+#include "include/llvm-libc-types/float128.h"
+
+#ifdef LIBC_TYPES_HAS_FLOAT128
+
+#include "src/__support/FPUtil/ManipulationFunctions.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+static constexpr float128 ldexpf128(float128 x, int exp) {
+ return fputil::ldexp(x, exp);
+}
+
+} // namespace math
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LIBC_TYPES_HAS_FLOAT128
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 60b8f83f6101d..4ad7e71387e6c 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1944,8 +1944,7 @@ add_entrypoint_object(
HDRS
../ldexpf128.h
DEPENDS
- libc.src.__support.macros.properties.types
- libc.src.__support.FPUtil.manipulation_functions
+ libc.src.__support.math.ldexpf128
)
add_object_library(
diff --git a/libc/src/math/generic/ldexpf128.cpp b/libc/src/math/generic/ldexpf128.cpp
index 03b1a2d2032e2..40afa5b285bcd 100644
--- a/libc/src/math/generic/ldexpf128.cpp
+++ b/libc/src/math/generic/ldexpf128.cpp
@@ -7,14 +7,13 @@
//===----------------------------------------------------------------------===//
#include "src/math/ldexpf128.h"
-#include "src/__support/FPUtil/ManipulationFunctions.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+
+#include "src/__support/math/ldexpf128.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(float128, ldexpf128, (float128 x, int exp)) {
- return fputil::ldexp(x, exp);
+ return math::ldexpf128(x, exp);
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 11ea06897f822..b429d662c4d34 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -2177,6 +2177,16 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_ldexpf128",
+ hdrs = ["src/__support/math/ldexpf128.h"],
+ deps = [
+ ":__support_fputil_manipulation_functions",
+ ":__support_macros_properties_types",
+ ":llvm_libc_types_float128"
+ ],
+)
+
############################### complex targets ################################
libc_function(
@@ -3330,7 +3340,12 @@ libc_math_function(name = "ldexpf")
libc_math_function(name = "ldexpl")
-libc_math_function(name = "ldexpf128")
+libc_math_function(
+ name = "ldexpf128",
+ additional_deps = [
+ ":__support_math_ldexpf128",
+ ],
+)
libc_math_function(name = "ldexpf16")
>From 697efcd8f4cd0a9e8009f4d97afd64b06575294b Mon Sep 17 00:00:00 2001
From: bassiounix <muhammad.m.bassiouni at gmail.com>
Date: Thu, 10 Jul 2025 09:55:59 +0300
Subject: [PATCH 2/3] [libc][math] Refactor ldexpf16 implementation to
header-only in src/__support/math folder.
---
libc/shared/math.h | 1 +
libc/shared/math/ldexpf16.h | 31 +++++++++++++++++
libc/src/__support/math/CMakeLists.txt | 10 ++++++
libc/src/__support/math/ldexpf16.h | 34 +++++++++++++++++++
libc/src/math/generic/CMakeLists.txt | 3 +-
libc/src/math/generic/ldexpf16.cpp | 7 ++--
.../llvm-project-overlay/libc/BUILD.bazel | 17 +++++++++-
7 files changed, 96 insertions(+), 7 deletions(-)
create mode 100644 libc/shared/math/ldexpf16.h
create mode 100644 libc/src/__support/math/ldexpf16.h
diff --git a/libc/shared/math.h b/libc/shared/math.h
index 7ad6b7ecb941f..ba6b1c2a7e28e 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -17,5 +17,6 @@
#include "math/frexpf128.h"
#include "math/frexpf16.h"
#include "math/ldexpf128.h"
+#include "math/ldexpf16.h"
#endif // LLVM_LIBC_SHARED_MATH_H
diff --git a/libc/shared/math/ldexpf16.h b/libc/shared/math/ldexpf16.h
new file mode 100644
index 0000000000000..d4e39c449943e
--- /dev/null
+++ b/libc/shared/math/ldexpf16.h
@@ -0,0 +1,31 @@
+//===-- Shared ldexpf16 function --------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_ldexpf16_H
+#define LLVM_LIBC_SHARED_MATH_ldexpf16_H
+
+#include "include/llvm-libc-macros/float16-macros.h"
+
+#ifdef LIBC_TYPES_HAS_FLOAT16
+
+#include "shared/libc_common.h"
+#include "src/__support/math/ldexpf16.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace shared {
+
+using math::ldexpf16;
+
+} // namespace shared
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LIBC_TYPES_HAS_FLOAT16
+
+#endif // LLVM_LIBC_SHARED_MATH_ldexpf16_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 4adfc33507e5d..2215695bd9e5f 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -92,3 +92,13 @@ add_header_library(
libc.src.__support.FPUtil.manipulation_functions
libc.include.llvm-libc-types.float128
)
+
+add_header_library(
+ ldexpf16
+ HDRS
+ ldexpf16.h
+ DEPENDS
+ libc.src.__support.macros.properties.types
+ libc.src.__support.FPUtil.manipulation_functions
+ libc.include.llvm-libc-macros.float16_macros
+)
diff --git a/libc/src/__support/math/ldexpf16.h b/libc/src/__support/math/ldexpf16.h
new file mode 100644
index 0000000000000..fbead87d909a8
--- /dev/null
+++ b/libc/src/__support/math/ldexpf16.h
@@ -0,0 +1,34 @@
+//===-- Implementation header for ldexpf16 ----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF16_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF16_H
+
+#include "include/llvm-libc-macros/float16-macros.h"
+
+#ifdef LIBC_TYPES_HAS_FLOAT16
+
+#include "src/__support/FPUtil/ManipulationFunctions.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+static constexpr float16 ldexpf16(float16 x, int exp) {
+ return fputil::ldexp(x, exp);
+}
+
+} // namespace math
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LIBC_TYPES_HAS_FLOAT16
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF16_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 4ad7e71387e6c..8be57cd97c3f3 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1933,8 +1933,7 @@ add_entrypoint_object(
HDRS
../ldexpf16.h
DEPENDS
- libc.src.__support.macros.properties.types
- libc.src.__support.FPUtil.manipulation_functions
+ libc.src.__support.math.ldexpf16
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/ldexpf16.cpp b/libc/src/math/generic/ldexpf16.cpp
index caa344b41476b..ecf16337ee79a 100644
--- a/libc/src/math/generic/ldexpf16.cpp
+++ b/libc/src/math/generic/ldexpf16.cpp
@@ -7,14 +7,13 @@
//===----------------------------------------------------------------------===//
#include "src/math/ldexpf16.h"
-#include "src/__support/FPUtil/ManipulationFunctions.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+
+#include "src/__support/math/ldexpf16.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(float16, ldexpf16, (float16 x, int exp)) {
- return fputil::ldexp(x, exp);
+ return math::ldexpf16(x, exp);
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index b429d662c4d34..5476a178bfc5a 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -2187,6 +2187,16 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_ldexpf16",
+ hdrs = ["src/__support/math/ldexpf16.h"],
+ deps = [
+ ":__support_macros_properties_types",
+ ":__support_fputil_manipulation_functions",
+ ":llvm_libc_macros_float16_macros"
+ ],
+)
+
############################### complex targets ################################
libc_function(
@@ -3347,7 +3357,12 @@ libc_math_function(
],
)
-libc_math_function(name = "ldexpf16")
+libc_math_function(
+ name = "ldexpf16",
+ additional_deps = [
+ ":__support_math_ldexpf16",
+ ],
+)
libc_math_function(name = "llogb")
>From 363a701dc4a1c24353e2415f0e32cc9cdd93ff98 Mon Sep 17 00:00:00 2001
From: bassiounix <muhammad.m.bassiouni at gmail.com>
Date: Thu, 10 Jul 2025 10:26:02 +0300
Subject: [PATCH 3/3] [libc][math] Refactor ldexpf implementation to
header-only in src/__support/math folder
---
libc/shared/math.h | 1 +
libc/shared/math/ldexpf.h | 23 +++++++++++++++
libc/src/__support/math/CMakeLists.txt | 8 ++++++
libc/src/__support/math/ldexpf.h | 28 +++++++++++++++++++
libc/src/math/generic/CMakeLists.txt | 2 +-
libc/src/math/generic/ldexpf.cpp | 6 ++--
.../llvm-project-overlay/libc/BUILD.bazel | 15 +++++++++-
7 files changed, 77 insertions(+), 6 deletions(-)
create mode 100644 libc/shared/math/ldexpf.h
create mode 100644 libc/src/__support/math/ldexpf.h
diff --git a/libc/shared/math.h b/libc/shared/math.h
index ba6b1c2a7e28e..b2f1a03e0940d 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -16,6 +16,7 @@
#include "math/frexpf.h"
#include "math/frexpf128.h"
#include "math/frexpf16.h"
+#include "math/ldexpf.h"
#include "math/ldexpf128.h"
#include "math/ldexpf16.h"
diff --git a/libc/shared/math/ldexpf.h b/libc/shared/math/ldexpf.h
new file mode 100644
index 0000000000000..497933c47321f
--- /dev/null
+++ b/libc/shared/math/ldexpf.h
@@ -0,0 +1,23 @@
+//===-- Shared ldexpf function ----------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_LDEXPF_H
+#define LLVM_LIBC_SHARED_MATH_LDEXPF_H
+
+#include "shared/libc_common.h"
+#include "src/__support/math/ldexpf.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::ldexpf;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SHARED_MATH_LDEXPF_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 2215695bd9e5f..900c0ab04d3a3 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -102,3 +102,11 @@ add_header_library(
libc.src.__support.FPUtil.manipulation_functions
libc.include.llvm-libc-macros.float16_macros
)
+
+add_header_library(
+ ldexpf
+ HDRS
+ ldexpf.h
+ DEPENDS
+ libc.src.__support.FPUtil.manipulation_functions
+)
diff --git a/libc/src/__support/math/ldexpf.h b/libc/src/__support/math/ldexpf.h
new file mode 100644
index 0000000000000..3a5ec1d471337
--- /dev/null
+++ b/libc/src/__support/math/ldexpf.h
@@ -0,0 +1,28 @@
+//===-- Implementation header for ldexpf ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF_H
+
+#include "src/__support/FPUtil/ManipulationFunctions.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+static constexpr float ldexpf(float x, int exp) {
+ return fputil::ldexp(x, exp);
+}
+
+} // namespace math
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 8be57cd97c3f3..a9237741788ae 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1913,7 +1913,7 @@ add_entrypoint_object(
HDRS
../ldexpf.h
DEPENDS
- libc.src.__support.FPUtil.manipulation_functions
+ libc.src.__support.math.ldexpf
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/ldexpf.cpp b/libc/src/math/generic/ldexpf.cpp
index 63c5d219f7a79..c5f30bb725e6b 100644
--- a/libc/src/math/generic/ldexpf.cpp
+++ b/libc/src/math/generic/ldexpf.cpp
@@ -7,14 +7,12 @@
//===----------------------------------------------------------------------===//
#include "src/math/ldexpf.h"
-#include "src/__support/FPUtil/ManipulationFunctions.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+#include "src/__support/math/ldexpf.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(float, ldexpf, (float x, int exp)) {
- return fputil::ldexp(x, exp);
+ return math::ldexpf(x, exp);
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 5476a178bfc5a..cd608a1352a7a 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -2197,6 +2197,14 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_ldexpf",
+ hdrs = ["src/__support/math/ldexpf.h"],
+ deps = [
+ ":__support_fputil_manipulation_functions",
+ ],
+)
+
############################### complex targets ################################
libc_function(
@@ -3346,7 +3354,12 @@ libc_math_function(name = "ilogbf16")
libc_math_function(name = "ldexp")
-libc_math_function(name = "ldexpf")
+libc_math_function(
+ name = "ldexpf",
+ additional_deps = [
+ ":__support_math_ldexpf",
+ ]
+)
libc_math_function(name = "ldexpl")
More information about the llvm-commits
mailing list