[libc] [llvm] [libc][math] Refactor frexpf implementation to header-only in src/__support/math folder. (PR #147893)
Muhammad Bassiouni via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 11 22:17:20 PDT 2025
https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/147893
>From a807ae119841e1849f261295878d7946b211583c Mon Sep 17 00:00:00 2001
From: bassiounix <muhammad.m.bassiouni at gmail.com>
Date: Thu, 10 Jul 2025 08:34:53 +0300
Subject: [PATCH 1/2] [libc][math] Refactor frexpf implementation to
header-only in src/__support/math folder.
---
libc/shared/math.h | 1 +
libc/shared/math/frexpf.h | 24 ++++++++++++++++
libc/src/__support/math/CMakeLists.txt | 8 ++++++
libc/src/__support/math/frexpf.h | 28 +++++++++++++++++++
libc/src/math/generic/CMakeLists.txt | 2 +-
libc/src/math/generic/frexpf.cpp | 7 ++---
.../llvm-project-overlay/libc/BUILD.bazel | 15 +++++++++-
7 files changed, 79 insertions(+), 6 deletions(-)
create mode 100644 libc/shared/math/frexpf.h
create mode 100644 libc/src/__support/math/frexpf.h
diff --git a/libc/shared/math.h b/libc/shared/math.h
index 4ddc29c7ae834..5cc592d676235 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -12,5 +12,6 @@
#include "libc_common.h"
#include "math/expf.h"
+#include "math/frexpf.h"
#endif // LLVM_LIBC_SHARED_MATH_H
diff --git a/libc/shared/math/frexpf.h b/libc/shared/math/frexpf.h
new file mode 100644
index 0000000000000..35f23a70eb253
--- /dev/null
+++ b/libc/shared/math/frexpf.h
@@ -0,0 +1,24 @@
+//===-- Shared frexpf function ------------------------------------*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SHARED_MATH_FREXPF_H
+#define LLVM_LIBC_SHARED_MATH_FREXPF_H
+
+#include "shared/libc_common.h"
+#include "src/__support/math/frexpf.h"
+
+namespace LIBC_NAMESPACE_DECL {
+namespace shared {
+
+using math::frexpf;
+
+} // namespace shared
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SHARED_MATH_FREXPF_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 66c1d19a1cab0..b531bd19257ee 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -22,3 +22,11 @@ add_header_library(
libc.src.__support.macros.config
libc.src.__support.macros.optimization
)
+
+add_header_library(
+ frexpf
+ HDRS
+ frexpf.h
+ DEPENDS
+ libc.src.__support.FPUtil.manipulation_functions
+)
diff --git a/libc/src/__support/math/frexpf.h b/libc/src/__support/math/frexpf.h
new file mode 100644
index 0000000000000..4d2f4948f2af6
--- /dev/null
+++ b/libc/src/__support/math/frexpf.h
@@ -0,0 +1,28 @@
+//===-- Implementation header for frexpf ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF_H
+#define LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF_H
+
+#include "src/__support/FPUtil/ManipulationFunctions.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+namespace math {
+
+static constexpr float frexpf(float x, int *exp) {
+ return fputil::frexp(x, *exp);
+}
+
+} // namespace math
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index fd1e6c0d648aa..8d6df4199b3a6 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1755,7 +1755,7 @@ add_entrypoint_object(
HDRS
../frexpf.h
DEPENDS
- libc.src.__support.FPUtil.manipulation_functions
+ libc.src.__support.math.frexpf
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/frexpf.cpp b/libc/src/math/generic/frexpf.cpp
index 09227badc3417..783880d44ce61 100644
--- a/libc/src/math/generic/frexpf.cpp
+++ b/libc/src/math/generic/frexpf.cpp
@@ -7,14 +7,13 @@
//===----------------------------------------------------------------------===//
#include "src/math/frexpf.h"
-#include "src/__support/FPUtil/ManipulationFunctions.h"
-#include "src/__support/common.h"
-#include "src/__support/macros/config.h"
+
+#include "src/__support/math/frexpf.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(float, frexpf, (float x, int *exp)) {
- return fputil::frexp(x, *exp);
+ return math::frexpf(x, exp);
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 2484a2f1e2bd7..8ed23334c82a6 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -2096,6 +2096,14 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_math_frexpf",
+ hdrs = ["src/__support/math/frexpf.h"],
+ deps = [
+ ":__support_fputil_manipulation_functions",
+ ],
+)
+
############################### complex targets ################################
libc_function(
@@ -3142,7 +3150,12 @@ libc_math_function(name = "fmulf128")
libc_math_function(name = "frexp")
-libc_math_function(name = "frexpf")
+libc_math_function(
+ name = "frexpf",
+ additional_deps = [
+ ":__support_math_frexpf",
+ ],
+)
libc_math_function(name = "frexpl")
>From 90824edeee97a08b4f2e8a5710c58d1fb9242571 Mon Sep 17 00:00:00 2001
From: bassiounix <muhammad.m.bassiouni at gmail.com>
Date: Sat, 12 Jul 2025 08:16:55 +0300
Subject: [PATCH 2/2] fix style
---
libc/shared/math.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libc/shared/math.h b/libc/shared/math.h
index 687af1f22ceb0..e2950e075a81d 100644
--- a/libc/shared/math.h
+++ b/libc/shared/math.h
@@ -13,8 +13,8 @@
#include "math/expf.h"
#include "math/expf16.h"
+#include "math/frexpf.h"
#include "math/frexpf128.h"
#include "math/frexpf16.h"
-#include "math/frexpf.h"
#endif // LLVM_LIBC_SHARED_MATH_H
More information about the llvm-commits
mailing list