[llvm] [llvm-objdump] Add inlined function display support (PR #142246)

[via llvm-commits]

gulfemsavrun wrote:

> Please don't force push to update PR branches once they have active reviewers, in line with the LLVM GitHub 
> 

Ack. Sorry 

> I think the format looks reasonable. I'm not certain about the naming though, as `line` doesn't really convey anything to me. I'm thinking something more like `limits-only` or something like that, but am also open to other ideas.
> 
> @MaskRay, @ostannard, @eugenis, paging you since you implemented or reviewed the original `--debug-vars` option, which this is closely tied to.



> Please don't force push to update PR branches once they have active reviewers, in line with the LLVM GitHub policy (see https://llvm.org/docs/GitHub.html#updating-pull-requests and the following section): it impairs the reviewing experience, making it harder and slower for me to review your changes. Also, please don't resolve conversations that I initiated, as I use the "resolved" status to track whether I'm happy with the response you've made (it's not unusual for people to miss/misunderstand/etc comments and do the wrong thing). I've gone into more detail on Discourse in the past on this topic.

Ack. Sorry about imparing your review experience. I pushed new patches into my branch and leave it up to you to resolve your comments.

> 
> Having given it a bit more thought, I don't think we want an extra option and it's fine to leave the behaviour as you've implemented. If users want to specify different formats for the two, that's on them.
> 
> > What are your thoughts on the line format that I added? This was a feature requested by some of our project developers who do not want to look at line-drawing characters.
> 
> I think the format looks reasonable. I'm not certain about the naming though, as `line` doesn't really convey anything to me. I'm thinking something more like `limits-only` or something like that, but am also open to other ideas.
> 
> @MaskRay, @ostannard, @eugenis, paging you since you implemented or reviewed the original `--debug-vars` option, which this is closely tied to.



https://github.com/llvm/llvm-project/pull/142246