[llvm] [SampleFDO][TypeProf]Support vtable type profiling for ext-binary and text format (PR #148002)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 10 10:04:34 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/ProfileData/SampleProf.h llvm/include/llvm/ProfileData/SampleProfReader.h llvm/include/llvm/ProfileData/SampleProfWriter.h llvm/lib/ProfileData/SampleProf.cpp llvm/lib/ProfileData/SampleProfReader.cpp llvm/lib/ProfileData/SampleProfWriter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/ProfileData/SampleProf.cpp b/llvm/lib/ProfileData/SampleProf.cpp
index d9ffec2e0..f87061864 100644
--- a/llvm/lib/ProfileData/SampleProf.cpp
+++ b/llvm/lib/ProfileData/SampleProf.cpp
@@ -229,7 +229,7 @@ void FunctionSamples::print(raw_ostream &OS, unsigned Indent) const {
       if (const TypeCountMap *TypeCountMap =
               this->findCallsiteTypeSamplesAt(Loc)) {
         OS.indent(Indent + 2);
-        printTypeCountMap(OS, Loc, *TypeCountMap); 
+        printTypeCountMap(OS, Loc, *TypeCountMap);
       }
     }
     OS.indent(Indent);
@@ -241,7 +241,7 @@ void FunctionSamples::print(raw_ostream &OS, unsigned Indent) const {
   OS.indent(Indent);
   if (!CallsiteSamples.empty()) {
     OS << "Samples collected in inlined callsites {\n";
-   SampleSorter<LineLocation, FunctionSamplesMap> SortedCallsiteSamples(
+    SampleSorter<LineLocation, FunctionSamplesMap> SortedCallsiteSamples(
         CallsiteSamples);
     for (const auto *Element : SortedCallsiteSamples.get()) {
       // Element is a pointer to a pair of LineLocation and FunctionSamplesMap.
@@ -249,8 +249,7 @@ void FunctionSamples::print(raw_ostream &OS, unsigned Indent) const {
       for (const FunctionSamples &FuncSample :
            llvm::make_second_range(FunctionSampleMap)) {
         OS.indent(Indent + 2);
-        OS << Loc << ": inlined callee: " << FuncSample.getFunction()
-           << ": ";
+        OS << Loc << ": inlined callee: " << FuncSample.getFunction() << ": ";
         FuncSample.print(OS, Indent + 4);
       }
       auto TypeSamplesIter = VirtualCallsiteTypeCounts.find(Loc);
diff --git a/llvm/lib/ProfileData/SampleProfWriter.cpp b/llvm/lib/ProfileData/SampleProfWriter.cpp
index a489c1c91..dfab404a6 100644
--- a/llvm/lib/ProfileData/SampleProfWriter.cpp
+++ b/llvm/lib/ProfileData/SampleProfWriter.cpp
@@ -619,10 +619,11 @@ std::error_code SampleProfileWriterText::writeSample(const FunctionSamples &S) {
   SampleSorter<LineLocation, FunctionSamplesMap> SortedCallsiteSamples(
       S.getCallsiteSamples());
   Indent += 1;
-  for (const auto* Element : SortedCallsiteSamples.get()) {
+  for (const auto *Element : SortedCallsiteSamples.get()) {
     // Element is a pointer to a pair of LineLocation and FunctionSamplesMap.
     const auto &[Loc, FunctionSamplesMap] = *Element;
-    for (const FunctionSamples &CalleeSamples : make_second_range(FunctionSamplesMap)) {
+    for (const FunctionSamples &CalleeSamples :
+         make_second_range(FunctionSamplesMap)) {
       OS.indent(Indent);
       Loc.print(OS);
       OS << ": ";

``````````

</details>


https://github.com/llvm/llvm-project/pull/148002


More information about the llvm-commits mailing list