[llvm] [ORC] Fix synchronization in CoreAPIsTest. (PR #144556)
Jameson Nash via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 9 12:56:23 PDT 2025
================
@@ -1559,16 +1559,13 @@ TEST_F(CoreAPIsStandardTest, TestLookupWithThreadedMaterialization) {
#if LLVM_ENABLE_THREADS
std::mutex WorkThreadsMutex;
- std::vector<std::thread> WorkThreads;
+ SmallVector<std::thread,0> WorkThreads;
DispatchOverride = [&](std::unique_ptr<Task> T) {
- std::promise<void> WaitP;
- std::lock_guard<std::mutex> Lock(WorkThreadsMutex);
+ std::unique_lock Lock(WorkThreadsMutex);
----------------
vtjnash wrote:
FWIW, it looks like LLVM now may consider `lock_guard` deprecated in favor of drive-by replacements of it with `unique_lock` everywhere? #126434 #146240
https://github.com/llvm/llvm-project/pull/144556
More information about the llvm-commits
mailing list