[llvm] [CI][Github] Remove MAX_PARALLEL_*_JOBS Args from Windows Runs (PR #147770)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 9 08:40:22 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-github-workflow
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
This patch removes setting the MAX_PARLLEL_COMPILE_JOBS and MAX_PARALLEL_LINK_JOBS env variables in the windows runs. These were originally used to control the parallelism on the old infrastructure and we set them on the new infrastructure explicitly so that we could maintain both at the same time. Now it does not make sense to keep them explicitly set that we do not need to explicitly control the parallelism given the amount of RAM we have on the machines. This also adds a maintnenace cost as evidenced by the fact that these have been incorrect (64 instead of 32) for quite a while.
---
Full diff: https://github.com/llvm/llvm-project/pull/147770.diff
2 Files Affected:
- (modified) .ci/monolithic-windows.sh (+1-3)
- (modified) .github/workflows/premerge.yaml (-2)
``````````diff
diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index c27111bf5aa10..176350fac604c 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -74,9 +74,7 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \
-D MLIR_ENABLE_BINDINGS_PYTHON=ON \
-D CMAKE_EXE_LINKER_FLAGS="/MANIFEST:NO" \
-D CMAKE_MODULE_LINKER_FLAGS="/MANIFEST:NO" \
- -D CMAKE_SHARED_LINKER_FLAGS="/MANIFEST:NO" \
- -D LLVM_PARALLEL_COMPILE_JOBS=${MAX_PARALLEL_COMPILE_JOBS} \
- -D LLVM_PARALLEL_LINK_JOBS=${MAX_PARALLEL_LINK_JOBS}
+ -D CMAKE_SHARED_LINKER_FLAGS="/MANIFEST:NO"
echo "::endgroup::"
echo "::group::ninja"
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 4435a3e905768..3b7751629564d 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -110,8 +110,6 @@ jobs:
if: ${{ steps.vars.outputs.windows-projects != '' }}
shell: cmd
run: |
- set MAX_PARALLEL_COMPILE_JOBS=64
- set MAX_PARALLEL_LINK_JOBS=64
call C:\\BuildTools\\Common7\\Tools\\VsDevCmd.bat -arch=amd64 -host_arch=amd64
bash .ci/monolithic-windows.sh "${{ steps.vars.outputs.windows-projects }}" "${{ steps.vars.outputs.windows-check-targets }}"
- name: Upload Artifacts
``````````
</details>
https://github.com/llvm/llvm-project/pull/147770
More information about the llvm-commits
mailing list