[llvm] [SelectionDAG] Correctly Mark Required Analyses (PR #147649)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-selectiondag

Author: Sam Elliott (lenary)

<details>
<summary>Changes</summary>

llvm/llvm-project#<!-- -->147560 changed when the legacy SelectionDAG pass needs TargetTransformInfoWrapperPass to always require it (rather than only when assertions are enabled). `SelectionDAGISelLegacy::getAnalysisUsage` was not updated in that PR, which was causing crashes on assertions-disabled builds, which are hard to track down.

This makes the required update, which should avoid crashes being seen on some buildbots and by some users.

---
Full diff: https://github.com/llvm/llvm-project/pull/147649.diff


1 Files Affected:

- (modified) llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (-2) 


``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
index 6260ad2f24dea..26071ed70c9db 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
@@ -396,9 +396,7 @@ void SelectionDAGISelLegacy::getAnalysisUsage(AnalysisUsage &AU) const {
   AU.addRequired<StackProtector>();
   AU.addPreserved<GCModuleInfo>();
   AU.addRequired<TargetLibraryInfoWrapperPass>();
-#ifndef NDEBUG
   AU.addRequired<TargetTransformInfoWrapperPass>();
-#endif
   AU.addRequired<AssumptionCacheTracker>();
   if (UseMBPI && OptLevel != CodeGenOptLevel::None)
       AU.addRequired<BranchProbabilityInfoWrapperPass>();

``````````

</details>


https://github.com/llvm/llvm-project/pull/147649