[llvm] [ARM] mlong-calls generate PIC code using GOT #39970 (PR #147313)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 7 15:50:12 PDT 2025


================
@@ -2839,7 +2846,8 @@ ARMTargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI,
             PtrVt, dl, DAG.getEntryNode(), Addr,
             MachinePointerInfo::getConstantPool(DAG.getMachineFunction()));
       }
-    } else if (ExternalSymbolSDNode *S=dyn_cast<ExternalSymbolSDNode>(Callee)) {
+    } else if (ExternalSymbolSDNode *S =
+                   dyn_cast<ExternalSymbolSDNode>(Callee)) {
       const char *Sym = S->getSymbol();
 
       if (Subtarget->genExecuteOnly()) {
----------------
efriedma-quic wrote:

Does the external-symbol codepath work correctly with PIC?  (I think you can trigger this with llvm.memset or something like that.)

https://github.com/llvm/llvm-project/pull/147313


More information about the llvm-commits mailing list