[llvm] Fix MSVC warning in benchmark (PR #147357)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 7 10:46:39 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-third-party-benchmark
Author: Daniel Paoliello (dpaoliello)
<details>
<summary>Changes</summary>
Building LLVM with MSVC is raising the following warning:
```
llvm\third-party\benchmark\src\sysinfo.cc(375): warning C4062: enumerator 'CacheUnknown' in switch of enum '_PROCESSOR_CACHE_TYPE' is not handled
```
This change resolves the warning by moving the `Unknown` type into a case block for `CacheUnknown`.
Not sure how this code flows back into the original source.
---
Full diff: https://github.com/llvm/llvm-project/pull/147357.diff
1 Files Affected:
- (modified) third-party/benchmark/src/sysinfo.cc (+3-1)
``````````diff
diff --git a/third-party/benchmark/src/sysinfo.cc b/third-party/benchmark/src/sysinfo.cc
index 3993ae17f7fc4..837be8f9cf891 100644
--- a/third-party/benchmark/src/sysinfo.cc
+++ b/third-party/benchmark/src/sysinfo.cc
@@ -358,7 +358,6 @@ std::vector<CPUInfo::CacheInfo> GetCacheSizesWindows() {
C.num_sharing = static_cast<int>(b.count());
C.level = cache.Level;
C.size = cache.Size;
- C.type = "Unknown";
switch (cache.Type) {
case CacheUnified:
C.type = "Unified";
@@ -372,6 +371,9 @@ std::vector<CPUInfo::CacheInfo> GetCacheSizesWindows() {
case CacheTrace:
C.type = "Trace";
break;
+ case CacheUnknown:
+ C.type = "Unknown";
+ break;
}
res.push_back(C);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/147357
More information about the llvm-commits
mailing list