[clang] [clang-tools-extra] [llvm] [clang][modules] Serialize `CodeGenOptions` (PR #146422)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 7 09:37:55 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,cl,c,h -- llvm/clang/test/Modules/implicit-opt-level.c clang-tools-extra/clangd/ModulesBuilder.cpp clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Frontend/ASTUnit.h clang/include/clang/Frontend/CompilerInstance.h clang/include/clang/Serialization/ASTBitCodes.h clang/include/clang/Serialization/ASTReader.h clang/include/clang/Serialization/ASTWriter.h clang/lib/Basic/CodeGenOptions.cpp clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/lib/Frontend/ASTUnit.cpp clang/lib/Frontend/ChainedIncludesSource.cpp clang/lib/Frontend/CompilerInstance.cpp clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Frontend/FrontendAction.cpp clang/lib/Frontend/FrontendActions.cpp clang/lib/Frontend/InitPreprocessor.cpp clang/lib/Frontend/PrecompiledPreamble.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp clang/lib/Serialization/GeneratePCH.cpp clang/test/PCH/no-validate-pch.cl
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/include/clang/Basic/CodeGenOptions.h b/clang/include/clang/Basic/CodeGenOptions.h
index 7cd5ea325..1c3b2719c 100644
--- a/clang/include/clang/Basic/CodeGenOptions.h
+++ b/clang/include/clang/Basic/CodeGenOptions.h
@@ -59,7 +59,8 @@ public:
using CFBranchLabelSchemeKind = CFBranchLabelSchemeKind;
using ProfileInstrKind = llvm::driver::ProfileInstrKind;
- using AsanDetectStackUseAfterReturnMode = llvm::AsanDetectStackUseAfterReturnMode;
+ using AsanDetectStackUseAfterReturnMode =
+ llvm::AsanDetectStackUseAfterReturnMode;
using AsanDtorKind = llvm::AsanDtorKind;
using VectorLibrary = llvm::driver::VectorLibrary;
using ZeroCallUsedRegsKind = llvm::ZeroCallUsedRegs::ZeroCallUsedRegsKind;
diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp b/clang/lib/CodeGen/CGDebugInfo.cpp
index 875356455..ef9f4b61d 100644
--- a/clang/lib/CodeGen/CGDebugInfo.cpp
+++ b/clang/lib/CodeGen/CGDebugInfo.cpp
@@ -5319,9 +5319,10 @@ void CGDebugInfo::EmitLabel(const LabelDecl *D, CGBuilderTy &Builder) {
StringRef Name = D->getName();
// Create the descriptor for the label.
- auto *L = DBuilder.createLabel(
- Scope, Name, Unit, Line, Column, /*IsArtificial=*/false,
- /*CoroSuspendIdx=*/std::nullopt, CGM.getCodeGenOpts().OptimizationLevel != 0);
+ auto *L = DBuilder.createLabel(Scope, Name, Unit, Line, Column,
+ /*IsArtificial=*/false,
+ /*CoroSuspendIdx=*/std::nullopt,
+ CGM.getCodeGenOpts().OptimizationLevel != 0);
// Insert an llvm.dbg.label into the current block.
DBuilder.insertLabel(L,
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 4a96e65bb..d0bb7fb1d 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -425,7 +425,7 @@ static bool checkCodegenOptions(const CodeGenOptions &CGOpts,
if ((CK::Compatibility == CK::NotCompatible) || \
(CK::Compatibility == CK::Compatible && \
!AllowCompatibleDifferences)) { \
- if (ExistingCGOpts.Name != CGOpts.Name) { \
+ if (ExistingCGOpts.Name != CGOpts.Name) { \
if (Diags) \
Diags->Report(diag::err_ast_file_codegenopt_value_mismatch) \
<< #Name << ModuleFilename; \
diff --git a/llvm/clang/test/Modules/implicit-opt-level.c b/llvm/clang/test/Modules/implicit-opt-level.c
index f6f1f58d3..e5dbb9eb4 100644
--- a/llvm/clang/test/Modules/implicit-opt-level.c
+++ b/llvm/clang/test/Modules/implicit-opt-level.c
@@ -5,11 +5,12 @@
// RUN: split-file %s %t
//--- module.modulemap
-module M { header "M.h" }
+module M{header "M.h"}
//--- M.h
//--- tu.c
#include "M.h"
-// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -O0 -fsyntax-only %t/tu.c
-// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -O1 -fsyntax-only %t/tu.c
-// RUN: find %t/cache -name "M-*.pcm" | count 2
+// RUN: %clang_cc1 -fmodules -fimplicit-module-maps
+// -fmodules-cache-path=%t/cache -O0 -fsyntax-only %t/tu.c RUN: %clang_cc1
+// -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -O1
+// -fsyntax-only %t/tu.c RUN: find %t/cache -name "M-*.pcm" | count 2
``````````
</details>
https://github.com/llvm/llvm-project/pull/146422
More information about the llvm-commits
mailing list