[llvm] [Object] Beginnings of SFrame parser and dumper (PR #147294)

via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 7 06:26:29 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- llvm/include/llvm/BinaryFormat/SFrame.h llvm/include/llvm/Object/SFrameParser.h llvm/lib/BinaryFormat/SFrame.cpp llvm/lib/Object/SFrameParser.cpp llvm/unittests/BinaryFormat/SFrameTest.cpp llvm/tools/llvm-readobj/ObjDumper.cpp llvm/tools/llvm-readobj/ObjDumper.h llvm/tools/llvm-readobj/llvm-readobj.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/BinaryFormat/SFrame.h b/llvm/include/llvm/BinaryFormat/SFrame.h
index fa2b2b4db..f58dad140 100644
--- a/llvm/include/llvm/BinaryFormat/SFrame.h
+++ b/llvm/include/llvm/BinaryFormat/SFrame.h
@@ -18,9 +18,9 @@
 #ifndef LLVM_BINARYFORMAT_SFRAME_H
 #define LLVM_BINARYFORMAT_SFRAME_H
 
+#include "llvm/ADT/ArrayRef.h"
 #include "llvm/Support/Compiler.h"
 #include "llvm/Support/DataTypes.h"
-#include "llvm/ADT/ArrayRef.h"
 
 namespace llvm {
 
diff --git a/llvm/lib/Object/SFrameParser.cpp b/llvm/lib/Object/SFrameParser.cpp
index 6f6d7ca2d..93d61a0e4 100644
--- a/llvm/lib/Object/SFrameParser.cpp
+++ b/llvm/lib/Object/SFrameParser.cpp
@@ -25,18 +25,18 @@ Expected<SFrameParser> SFrameParser::create(ArrayRef<uint8_t> Contents) {
     return Cursor.takeError();
 
   switch (Preamble.sfp_magic) {
-    case SFRAME_MAGIC:
-      break;
-    case byteswap(SFRAME_MAGIC):
-      // Fix endianness.
-      Preamble.sfp_magic = SFRAME_MAGIC;
-      // And make sure everything that comes afterwards is read correctly.
-      Data = DataExtractor(Data.getData(), !Data.isLittleEndian(),
-                           Data.getAddressSize());
-      break;
-    default:
-      return make_error<GenericBinaryError>("invalid magic number",
-                                            object_error::parse_failed);
+  case SFRAME_MAGIC:
+    break;
+  case byteswap(SFRAME_MAGIC):
+    // Fix endianness.
+    Preamble.sfp_magic = SFRAME_MAGIC;
+    // And make sure everything that comes afterwards is read correctly.
+    Data = DataExtractor(Data.getData(), !Data.isLittleEndian(),
+                         Data.getAddressSize());
+    break;
+  default:
+    return make_error<GenericBinaryError>("invalid magic number",
+                                          object_error::parse_failed);
   }
   Preamble.sfp_version = Data.getU8(Cursor);
   Preamble.sfp_flags = Data.getU8(Cursor);

``````````

</details>


https://github.com/llvm/llvm-project/pull/147294


More information about the llvm-commits mailing list