[llvm] 1113224 - [VectorCombine] Account for IRBuilder simplification in translateExt.

[Florian Hahn via llvm-commits]

Author: Florian Hahn
Date: 2025-07-07T13:39:39+02:00
New Revision: 1113224f9444f5c2cf69784cd3c110b8dd560897

URL: https://github.com/llvm/llvm-project/commit/1113224f9444f5c2cf69784cd3c110b8dd560897
DIFF: https://github.com/llvm/llvm-project/commit/1113224f9444f5c2cf69784cd3c110b8dd560897.diff

LOG: [VectorCombine] Account for IRBuilder simplification in translateExt.

After https://github.com/llvm/llvm-project/pull/146350,
CreateExtractElement may return a folded value and not create an
ExtractElement instruction.

Replace cast with dyn_cast. Note that the function returns nullptr
already earlier if the extract may be constant folded.

Fixes https://github.com/llvm/llvm-project/issues/147218

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/VectorCombine.cpp
    llvm/test/Transforms/VectorCombine/X86/extract-binop.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
index b9ce20ebd3e63..fe8d74c43dfdc 100644
--- a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
+++ b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
@@ -563,7 +563,8 @@ static ExtractElementInst *translateExtract(ExtractElementInst *ExtElt,
 
   Value *Shuf = createShiftShuffle(X, cast<ConstantInt>(C)->getZExtValue(),
                                    NewIndex, Builder);
-  return cast<ExtractElementInst>(Builder.CreateExtractElement(Shuf, NewIndex));
+  return dyn_cast<ExtractElementInst>(
+      Builder.CreateExtractElement(Shuf, NewIndex));
 }
 
 /// Try to reduce extract element costs by converting scalar compares to vector

diff  --git a/llvm/test/Transforms/VectorCombine/X86/extract-binop.ll b/llvm/test/Transforms/VectorCombine/X86/extract-binop.ll
index 7cbe1c6cec906..d11fb1426c94e 100644
--- a/llvm/test/Transforms/VectorCombine/X86/extract-binop.ll
+++ b/llvm/test/Transforms/VectorCombine/X86/extract-binop.ll
@@ -567,3 +567,22 @@ define float @constant_fold_crash_commute(<4 x float> %x) {
   %c = fadd float %b, %a
   ret float %c
 }
+
+; Test case for https://github.com/llvm/llvm-project/issues/147218.
+define i64 @instsimplify_folder_crash(<4 x i64> %in) {
+; CHECK-LABEL: @instsimplify_folder_crash(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    [[SHUFFLE_1:%.*]] = shufflevector <4 x i64> [[IN:%.*]], <4 x i64> zeroinitializer, <4 x i32> <i32 4, i32 5, i32 2, i32 3>
+; CHECK-NEXT:    [[E_0:%.*]] = extractelement <4 x i64> zeroinitializer, i64 0
+; CHECK-NEXT:    [[E_1:%.*]] = extractelement <4 x i64> [[SHUFFLE_1]], i64 1
+; CHECK-NEXT:    [[OR:%.*]] = or i64 [[E_1]], [[E_0]]
+; CHECK-NEXT:    ret i64 [[OR]]
+;
+entry:
+  %shuffle.1 = shufflevector <4 x i64> %in, <4 x i64> zeroinitializer, <4 x i32> <i32 4, i32 5, i32 2, i32 3>
+  %e.0 = extractelement <4 x i64> zeroinitializer, i64 0
+  %e.1 = extractelement <4 x i64> %shuffle.1, i64 1
+  %shift = shufflevector <4 x i64> %shuffle.1, <4 x i64> poison, <4 x i32> <i32 1, i32 poison, i32 poison, i32 poison>
+  %or = or i64 %e.1, %e.0
+  ret i64 %or
+}