[llvm] [LoopInterchange] Defer CacheCost calculation until needed (PR #146874)

Sjoerd Meijer via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 7 03:02:52 PDT 2025


================
@@ -407,6 +407,33 @@ class LoopInterchangeLegality {
   SmallVector<PHINode *, 8> InnerLoopInductions;
 };
 
+/// Manages information utilized by the profitability check for cache. The main
+/// purpose of this class is to delay the computation of CacheCost until it is
+/// actually needed.
+class LoopInterchangeCacheCostManager {
----------------
sjoerdmeijer wrote:

Bikeshedding names: 
- If there is no requirement to prefix the pass name for each helper class, then I would prefer `LoopInterchangeCacheCostManager` -> `CacheCostManager` because it is easier to read; I think it's equally descriptive. 
- And similarly, if we can rename `LICCM` -> `CostManager` or something along those lines, that would help, I think. All these 3, 4, or 5 letter acronyms make things difficult to read. 

https://github.com/llvm/llvm-project/pull/146874


More information about the llvm-commits mailing list