[llvm] [AMDGPU] SelectionDAG divergence tracking should take into account Target divergency. (PR #144947)

Thu Jul 3 18:51:00 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `llvm` at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/21996

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
...
2.796 [10/54/723] Linking CXX executable unittests/tools/llvm-exegesis/LLVMExegesisTests
3.426 [10/53/724] Linking CXX executable unittests/Target/TargetMachineCTests
3.698 [10/52/725] Linking CXX executable unittests/MI/MITests
3.751 [10/51/726] Linking CXX executable tools/lld/unittests/AsLibELF/LLDAsLibELFTests
3.923 [10/50/727] Linking CXX executable unittests/DebugInfo/DWARF/DebugInfoDWARFTests
3.942 [10/49/728] Linking CXX executable unittests/DebugInfo/LogicalView/DebugInfoLogicalViewTests
4.251 [10/48/729] Linking CXX executable tools/lld/unittests/AsLibAll/LLDAsLibAllTests
5.984 [10/47/730] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TypeTraitsTest.cpp.o
6.062 [10/46/731] Building CXX object unittests/Target/VE/CMakeFiles/VETests.dir/MachineInstrTest.cpp.o
6.535 [9/46/732] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o
FAILED: unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/clang++ -DEXPENSIVE_CHECKS -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/llvm-clang-x86_64-expensive-checks-debian/build/unittests/Target/AArch64 -I/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/unittests/Target/AArch64 -I/b/1/llvm-clang-x86_64-expensive-checks-debian/build/include -I/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/include -I/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/Target/AArch64 -I/b/1/llvm-clang-x86_64-expensive-checks-debian/build/lib/Target/AArch64 -I/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/third-party/unittest/googletest/include -I/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/third-party/unittest/googlemock/include -U_GLIBCXX_DEBUG -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -MF unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o.d -o unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -c /b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp:65:10: error: no matching member function for call to 'init'
    DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, MMI,
    ~~~~~^~~~
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:472:17: note: candidate function not viable: requires 10 arguments, but 9 were provided
  LLVM_ABI void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
                ^
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:478:8: note: candidate function not viable: requires 10 arguments, but 9 were provided
  void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
       ^
1 error generated.
7.101 [9/45/733] Linking CXX executable unittests/Target/VE/VETests
7.494 [9/44/734] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AddressingModes.cpp.o
7.518 [9/43/735] Building CXX object unittests/Target/LoongArch/CMakeFiles/LoongArchTests.dir/InstSizes.cpp.o
7.716 [9/42/736] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/MatrixRegisterAliasing.cpp.o
8.576 [9/41/737] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/GISelAliasTest.cpp.o
8.651 [9/40/738] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SVESchedPseudoTest.cpp.o
8.680 [9/39/739] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/Immediates.cpp.o
8.683 [9/38/740] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/CCStateTest.cpp.o
8.736 [9/37/741] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/LegalizerTest.cpp.o
8.743 [9/36/742] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64RegisterInfoTest.cpp.o
8.787 [9/35/743] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/SelectionDAGAddressAnalysisTest.cpp.o
8.848 [9/34/744] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/InstructionSelectTest.cpp.o
9.027 [9/33/745] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/GISelUtilsTest.cpp.o
9.040 [9/32/746] Building CXX object unittests/MIR/CMakeFiles/MIRTests.dir/MachineMetadata.cpp.o
9.059 [9/31/747] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineOperandTest.cpp.o
9.086 [9/30/748] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/RegAllocScoreTest.cpp.o
9.115 [9/29/749] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/X86MCInstLowerTest.cpp.o
9.228 [9/28/750] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/SchedBoundary.cpp.o
9.300 [9/27/751] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/GISelMITest.cpp.o
9.305 [9/26/752] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/MachineIRBuilderTest.cpp.o
9.430 [9/25/753] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/KnownFPClassTest.cpp.o
9.465 [9/24/754] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/InstSizes.cpp.o
9.475 [9/23/755] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineBasicBlockTest.cpp.o
9.500 [9/22/756] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/ConstantFoldingTest.cpp.o
9.567 [9/21/757] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o
9.944 [9/20/758] Building CXX object unittests/Target/ARM/CMakeFiles/ARMTests.dir/MachineInstrTest.cpp.o
10.057 [9/19/759] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/KnownBitsVectorTest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/144947