[llvm] 60d1c4e - [llvm] Use range-based for loops (NFC) (#146945)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 3 17:54:21 PDT 2025


Author: Kazu Hirata
Date: 2025-07-03T17:54:17-07:00
New Revision: 60d1c4e257ed531e1209eb841af046df2247206b

URL: https://github.com/llvm/llvm-project/commit/60d1c4e257ed531e1209eb841af046df2247206b
DIFF: https://github.com/llvm/llvm-project/commit/60d1c4e257ed531e1209eb841af046df2247206b.diff

LOG: [llvm] Use range-based for loops (NFC) (#146945)

Note that LLVM Coding Standards discourages std::for_each and
llvm::for_each unless the callable object already exists.

Added: 
    

Modified: 
    llvm/lib/Target/M68k/M68kInstrInfo.cpp
    llvm/lib/Transforms/Coroutines/SpillUtils.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/M68k/M68kInstrInfo.cpp b/llvm/lib/Target/M68k/M68kInstrInfo.cpp
index 568938f1f50b7..21e9319aaf0b3 100644
--- a/llvm/lib/Target/M68k/M68kInstrInfo.cpp
+++ b/llvm/lib/Target/M68k/M68kInstrInfo.cpp
@@ -95,8 +95,8 @@ bool M68kInstrInfo::AnalyzeBranchImpl(MachineBasicBlock &MBB,
   // Erase any instructions if allowed at the end of the scope.
   std::vector<std::reference_wrapper<llvm::MachineInstr>> EraseList;
   auto FinalizeOnReturn = llvm::make_scope_exit([&EraseList] {
-    std::for_each(EraseList.begin(), EraseList.end(),
-                  [](auto &ref) { ref.get().eraseFromParent(); });
+    for (auto &Ref : EraseList)
+      Ref.get().eraseFromParent();
   });
 
   // Start from the bottom of the block and work up, examining the

diff  --git a/llvm/lib/Transforms/Coroutines/SpillUtils.cpp b/llvm/lib/Transforms/Coroutines/SpillUtils.cpp
index b3e5b7fa6e0b5..8017db1cfe146 100644
--- a/llvm/lib/Transforms/Coroutines/SpillUtils.cpp
+++ b/llvm/lib/Transforms/Coroutines/SpillUtils.cpp
@@ -552,10 +552,10 @@ void sinkSpillUsesAfterCoroBegin(const DominatorTree &Dom,
         Worklist.push_back(Inst);
     }
   };
-  std::for_each(Spills.begin(), Spills.end(),
-                [&](auto &I) { collectUsers(I.first); });
-  std::for_each(Allocas.begin(), Allocas.end(),
-                [&](auto &I) { collectUsers(I.Alloca); });
+  for (auto &I : Spills)
+    collectUsers(I.first);
+  for (auto &I : Allocas)
+    collectUsers(I.Alloca);
 
   // Recursively collect users before coro.begin.
   while (!Worklist.empty()) {


        


More information about the llvm-commits mailing list